Skip to content

Remove obsolete pkg_resource import#146

Merged
LeoQuote merged 2 commits intodouban:masterfrom
dispensable:remove_pkg_resource
May 8, 2026
Merged

Remove obsolete pkg_resource import#146
LeoQuote merged 2 commits intodouban:masterfrom
dispensable:remove_pkg_resource

Conversation

@dispensable
Copy link
Copy Markdown
Contributor

removes the legacy setuptools >= 18.0 check utilizing pkg_resources.

setuptools >= 82.0.0 has completely dropped the pkg_resources module, causing ModuleNotFoundError during modern builds (e.g., Python 3.12). Since setuptools 18.0 was released in 2015, even legacy Python 2.7 environments naturally exceed this requirement.

Removing this redundant self-check safely restores compatibility with modern build frontends without breaking older environments.

@dispensable dispensable requested a review from LeoQuote May 8, 2026 04:09
@LeoQuote LeoQuote merged commit 1cc80c2 into douban:master May 8, 2026
28 checks passed
@dispensable dispensable deleted the remove_pkg_resource branch May 8, 2026 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants