Attach lock context to overloaded exceptions for better metrics#18
Draft
dpep wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Berater::Overloaded#lockand an initializer that accepts aLockinstance so overload exceptions can carry lock details.StaticLimiter,RateLimiter,ConcurrencyLimiter,Inhibitor) to raiseOverloaded.new(Lock.new(...))with the appropriatecapacityandcount/contentionwhen the request is refused.Statsdmiddleware to useerror.lockwhen nolockwas returned so lock gauges are emitted for overload events.Tracemiddleware to retrieve lock info fromerror.lockwhen applicable so traces can still tag contention on overloads, and update specs to assert the new behavior.Testing
spec/middleware/statsd_spec.rbandspec/middleware/trace_spec.rbto validate lock-based metrics/tags are captured from the overloaded exception's lock; these specs were modified alongside code changes.bundle exec rspec spec/middleware/statsd_spec.rb spec/middleware/trace_spec.rb spec/concurrency_limiter_spec.rb spec/rate_limiter_spec.rb spec/static_limiter_spec.rb spec/inhibitor_spec.rbbut the environment cannot run them here:bundler: command not found: rspec.Codex Task