Harden Echo AI provider request and error handling - #1642
Closed
aapomm wants to merge 4 commits into
Closed
Conversation
Upstream error bodies were broadcast verbatim to the client, leaking internal service responses. Log the detail server-side and show a generic message instead.
build_uri used the address verbatim, giving full request-path control. Treat address as a base URL and append /messages, matching the other providers.
Contributor
Author
|
Closing in favor of #1648 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves how the Dradis Echo AI provider integration handles requests and errors (relates to #1641).
InteractionJobpreviously broadcast the upstream provider's raw response/error to the browser. It now logs the detail server-side and shows the user a generic "Something went wrong." message.Provider::Anthropicnow treatsaddressas a base URL and appends/messages, matching how the OpenAI and Gemini providers build their request URLs.delete_suffix('/messages')keeps existing providers (and full-URL entries) working.Testing steps
.../v1/messageswhether the address is set to the base URL or the full endpoint.Other Information
Full
dradis-echosuite passes (101 examples), rubocop clean.Check List