add proactive edit locking for issues - #1658
Open
MattBudz wants to merge 15 commits into
Open
Conversation
qa/_state_button.html.erb opened .btn-group but never closed it, relying on the caller to supply the closing tag. This happened to work by coincidence as long as the caller's own div count matched, but breaks non-browser HTML parsers (and any caller with a different div count) since the tag is genuinely unbalanced.
aapomm
reviewed
Jul 24, 2026
aapomm
reviewed
Jul 24, 2026
aapomm
reviewed
Jul 24, 2026
qa/_state_button.html.erb now closes its own .btn-group div, which exposed a stray closing div at the end of the form partial that used to cancel it out. The mismatch made the browser relocate the <form> element during HTML parsing, collapsing the two-column edit layout. Nest the Cancel link inside .form-actions.sticky and close it once.
c1a3654 included db/development.sqlite3, db/test.sqlite3, and db/production.sqlite3 via a broad git add. The development database carries a Configuration row with an absolute path under /Users/aaron, which breaks db:rollback/db:migrate on any other machine. Ignore db/*.sqlite3* going forward so this doesn't happen again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds proactive edit locking for Issues: when a user opens the edit form for an issue that another user already has open, they see a lockout screen instead of the form, with the option to go back or edit anyway. This replaces the previous approach of only warning about conflicts after save.
Testing steps
Check List