fix: properly render seedClient volumeClaimTemplate annotations#512
Open
r3nic1e wants to merge 1 commit into
Open
fix: properly render seedClient volumeClaimTemplate annotations#512r3nic1e wants to merge 1 commit into
r3nic1e wants to merge 1 commit into
Conversation
r3nic1e
force-pushed
the
fix/vc-template-annotations
branch
from
0cbb962 to
1e3c050
Compare
Signed-off-by: Sviatoslav Dumchenko <zcbr95+github@gmail.com>
r3nic1e
force-pushed
the
fix/vc-template-annotations
branch
from
1e3c050 to
6850d9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
annotations:line to volumeClaimTemplate annotations template for seed-client statefulsettoYaml | nindentinstead ofrangefor rendering annotations mapRelated Issue
#511
Motivation and Context
There was
annotations:line missing in the template so rendering failed if annotations are specified. Also this code used a bit different pattern of rendering map -rangeinstead oftoYamlthat is used in every other places.