Skip to content

Update dependency php to >=8.5.4 #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexSkrypnyk wants to merge 1 commit into from
Closed

Update dependency php to >=8.5.4 #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/themes/custom/drevops/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "drupal-theme",
"license": "proprietary",
"require": {
"php": ">=8.3"
"php": ">=8.5.4"
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== composer.json PHP constraints =="
python - <<'PY'
import json, pathlib
for p in pathlib.Path('.').rglob('composer.json'):
    try:
        data = json.loads(p.read_text())
    except Exception:
        continue
    php_req = (data.get('require') or {}).get('php')
    if php_req is not None:
        print(f"{p}\t{php_req}")
PY

echo
echo "== Referenced PHP versions in CI/docs/tooling =="
rg -n --glob '**/*.yml' --glob '**/*.yaml' --glob '**/Dockerfile*' --glob '**/.tool-versions' --glob '**/*.md' '8\.5\.4|8\.5|8\.4|8\.3|php-version|platform\.php'

Repository: drevops/website

Length of output: 380

Use a bounded PHP constraint instead of >=8.5.4.

The constraint at line 7 excludes PHP 8.5.0–8.5.3 and implicitly allows future major versions without clear justification. The root composer.json uses >=8.3, making this theme's jump to >=8.5.4 inconsistent and unnecessarily restrictive. Use ^8.5 unless 8.5.4 is explicitly required by a documented runtime fix.

Suggested constraint update 
-        "php": ">=8.5.4"
+        "php": "^8.5"

If 8.5.4 patch floor is required:

-        "php": ">=8.5.4"
+        "php": "^8.5.4"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"php": ">=8.5.4"
"php": "^8.5"
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@web/themes/custom/drevops/composer.json` at line 7, Replace the overly strict
"php" constraint in the theme's composer.json: change the "php": ">=8.5.4" entry
to a bounded constraint (e.g., "php": "^8.5") to allow normal semver updates and
align with the project's intent; if you truly require a minimum patch of 8.5.4,
use a bounded range like "php": ">=8.5.4 <9.0" instead. Ensure you update the
"php" key in composer.json (the existing "php" constraint) accordingly.

},
"extra": {
"civictheme": {
Expand Down
Loading