Skip to content

Updated brand colours. #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexSkrypnyk wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Updated brand colours. #152

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
398920c
Updated brand colours.
AlexSkrypnyk Mar 13, 2026
93f5967
Updated deps.
AlexSkrypnyk Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions web/themes/custom/drevops/components/variables.base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@

$ct-colors-brands: (
'light': (
'brand1': #00698f,
'brand2': #e6e9eb,
'brand3': #121313,
'brand1': #d4725e,
'brand2': #f8f4f2,
'brand3': #1a2836,
),
'dark': (
'brand1': #61daff,
'brand2': #003a4f,
'brand3': #00698f,
'brand1': #e8a090,
'brand2': #1a2836,
'brand3': #d4725e,
Comment on lines +17 to +24
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Run contrast/visual regression checks for both themes before merge.

Given these are core brand tokens, please validate impacted UI surfaces (e.g., text on brand backgrounds, buttons, links) for WCAG contrast in light and dark themes.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@web/themes/custom/drevops/components/variables.base.scss` around lines 17 -
24, Update the PR by running WCAG contrast and visual regression checks for the
theme color tokens defined in variables.base.scss — specifically the 'light' and
'dark' maps and their 'brand1', 'brand2', 'brand3' entries — across impacted UI
surfaces (text on brand backgrounds, buttons, links). Use an automated contrast
checker (e.g., axe-core, pa11y, or Lighthouse) and a visual regression tool
(e.g., Percy, Chromatic, or Playwright snapshots) to validate both themes; if
any checks fail, adjust the token values in the 'light'/'dark' maps or update
component styles to meet AA/AAA thresholds and attach failing screenshots/diffs
and updated token changes to the PR for reviewer verification.

)
);

Expand Down
Loading