Updated Drupal core and contrib modules.#165
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughUpdated Composer dependency version constraints for multiple packages (both Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@composer.json`:
- Line 53: Update the explicit symfony/http-client constraint in composer.json
so it doesn't conflict with Drupal 11's Symfony 7 requirement: either remove the
"symfony/http-client" entry entirely to let drupal/core-recommended control the
version, or change its version constraint from "^6.4.36" to a Symfony 7
compatible constraint such as "^7.4.8"; ensure after the change you run composer
update to verify the dependency graph resolves against drupal/core-recommended
~11.3.7.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 0518af50-9ecc-4f0a-b3da-ebb2cf63a165
⛔ Files ignored due to path filters (1)
composer.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
composer.json
| "drush/drush": "^13.7.2", | ||
| "oomphinc/composer-installers-extender": "^2.0.1", | ||
| "symfony/http-client": "^6.4.34", | ||
| "symfony/http-client": "^6.4.36", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Direct constraint in composer.json =="
rg -n '"symfony/http-client"\s*:' composer.json
echo
echo "== Resolved version in composer.lock (if present) =="
jq -r '.packages[] | select(.name=="symfony/http-client") | "\(.name) \(.version)"' composer.lock
echo
echo "== Why package is required (dependency chain) =="
composer why symfony/http-client || true
echo
echo "== Check whether Symfony 7.4.8 is prohibited and by whom =="
composer prohibits symfony/http-client 7.4.8 || trueRepository: drevops/website
Length of output: 505
🏁 Script executed:
cat -n composer.json | head -90 | tail -50Repository: drevops/website
Length of output: 2298
🏁 Script executed:
# Search for all symfony package constraints in composer.json
rg -n 'symfony/' composer.jsonRepository: drevops/website
Length of output: 103
🏁 Script executed:
# Check what version of Drupal core requires Symfony
# Examine if drupal/core-recommended ~11.3.7 has any Symfony constraints documented
rg -n '"drupal/core' composer.jsonRepository: drevops/website
Length of output: 254
🌐 Web query:
Drupal 11 Symfony version requirement
💡 Result:
Drupal 11 requires Symfony 7 (specifically ^7.4 for various components like symfony/console, symfony/http-foundation, etc., as defined in Drupal core's composer.json dependencies). Drupal 11.0.0 ships with Symfony 7.1.1.
Citations:
- 1: https://drupalize.me/guide/symfony-drupal-developers
- 2: https://www.drupal.org/project/drupal/issues/3284879
- 3: https://www.drupal.org/about/core/blog/drupal-110-will-require-php-83-and-mysql-80
- 4: https://www.drupal.org/project/drupal/releases/11.0.0
- 5: https://github.com/drupal/drupal/blob/11.x/composer.lock
- 6: https://github.com/drupal/recommended-project/blob/11.x/composer.lock
Remove or upgrade explicit symfony/http-client constraint to align with Drupal 11 requirements.
Line 53 pins symfony/http-client to ^6.4.36, which conflicts with drupal/core-recommended ~11.3.7 (Drupal 11 requires Symfony ^7.4). This constraint will block Symfony 7.x resolution. Either upgrade to ^7.4.8 to match your Symfony 7 stack or remove the constraint entirely to let drupal/core-recommended control the version.
Proposed fix
- "symfony/http-client": "^6.4.36",
+ "symfony/http-client": "^7.4.8",Or remove the constraint if not explicitly needed:
- "symfony/http-client": "^6.4.36",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "symfony/http-client": "^6.4.36", | |
| "symfony/http-client": "^7.4.8", |
| "symfony/http-client": "^6.4.36", |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@composer.json` at line 53, Update the explicit symfony/http-client constraint
in composer.json so it doesn't conflict with Drupal 11's Symfony 7 requirement:
either remove the "symfony/http-client" entry entirely to let
drupal/core-recommended control the version, or change its version constraint
from "^6.4.36" to a Symfony 7 compatible constraint such as "^7.4.8"; ensure
after the change you run composer update to verify the dependency graph resolves
against drupal/core-recommended ~11.3.7.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #165 +/- ##
========================================
Coverage 87.73% 87.73%
========================================
Files 11 11
Lines 163 163
========================================
Hits 143 143
Misses 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Code coverage (GitHub Actions) |
Summary
Updated Drupal core from
11.3.5to11.3.7and aligned the full Symfony stack to7.4.8. Updated 57 packages in total, covering core, contrib modules, and developer tooling including Drush, Rector, PHPStan, and Behat. All changes are patch or minor releases with no breaking changes expected. No security advisories were reported.Changes
11.3.5to11.3.7- a patch-level stability release.7.4.8across the full HTTP and routing stack.Key highlights
11.3.5to11.3.7- two patch releases with bug fixes and stability improvements.7.4.8- covers HTTP kernel, routing, mailer, serializer, validation, and more.1.33.0to1.36.0(minor) for PHP 81/83 compatibility layers.13.7.1to13.7.2with Consolidation library patches.2.3.9to2.4.2(minor) and PHPStan2.1.44to2.1.49for improved static analysis.3.29.0to3.30.0, drupal-extension5.3.2to5.3.3, behat-steps3.6.0to3.7.0.1.3.0to1.3.3.Testing focus
Overall impact
This update brings Drupal core forward by two patch releases and aligns the entire Symfony stack to the latest patch level. The changes are conservative and focused on bug fixes and internal stability improvements rather than new features.
The risk profile is low. All core and framework changes are patch-level, and the minor bumps in developer tooling and testing libraries do not affect production runtime behaviour. The Symfony unification to a single patch version reduces version fragmentation across the dependency tree.
No security advisories were reported. The update is routine maintenance that keeps the platform current and reduces the delta for future updates.
Package changes
behat/behat updated from
3.29.0to3.30.0minorSee changes: Behat/Behat@v3.29.0...v3.30.0
Release notes: https://github.com/Behat/Behat/releases/tag/v3.30.0
consolidation/annotated-command updated from
4.10.4to4.10.5patchSee changes: consolidation/annotated-command@4.10.4...4.10.5
Release notes: https://github.com/consolidation/annotated-command/releases/tag/4.10.5
consolidation/config updated from
3.2.0to3.2.1patchSee changes: consolidation/config@3.2.0...3.2.1
Release notes: https://github.com/consolidation/config/releases/tag/3.2.1
consolidation/log updated from
3.1.1to3.1.2patchSee changes: consolidation/log@3.1.1...3.1.2
Release notes: https://github.com/consolidation/log/releases/tag/3.1.2
consolidation/output-formatters updated from
4.7.0to4.7.1patchSee changes: consolidation/output-formatters@4.7.0...4.7.1
Release notes: https://github.com/consolidation/output-formatters/releases/tag/4.7.1
consolidation/site-alias updated from
4.1.2to4.1.3patchSee changes: consolidation/site-alias@4.1.2...4.1.3
Release notes: https://github.com/consolidation/site-alias/releases/tag/4.1.3
dantleech/gherkin-lint updated from
0.2.3to0.2.4patchSee changes: dantleech/gherkin-lint-php@0.2.3...0.2.4
Release notes: https://github.com/dantleech/gherkin-lint-php/releases/tag/0.2.4
drevops/behat-screenshot updated from
2.2.0to2.3.0minorSee changes: drevops/behat-screenshot@2.2.0...2.3.0
Release notes: https://github.com/drevops/behat-screenshot/releases/tag/2.3.0
drevops/behat-steps updated from
3.6.0to3.7.0minorSee changes: drevops/behat-steps@3.6.0...3.7.0
Release notes: https://github.com/drevops/behat-steps/releases/tag/3.7.0
drupal/ai updated from
1.3.0to1.3.3patchdrupal/core updated from
11.3.5to11.3.7patchSee changes: drupal/core@11.3.5...11.3.7
Release notes: https://github.com/drupal/core/releases/tag/11.3.7
drupal/core-composer-scaffold updated from
11.3.5to11.3.7patchSee changes: drupal/core-composer-scaffold@11.3.5...11.3.7
Release notes: https://github.com/drupal/core-composer-scaffold/releases/tag/11.3.7
drupal/core-recommended updated from
11.3.5to11.3.7patchSee changes: drupal/core-recommended@11.3.5...11.3.7
Release notes: https://github.com/drupal/core-recommended/releases/tag/11.3.7
drupal/drupal-extension updated from
5.3.2to5.3.3patchSee changes: jhedstrom/drupalextension@v5.3.2...v5.3.3
Release notes: https://github.com/jhedstrom/drupalextension/releases/tag/v5.3.3
drush/drush updated from
13.7.1to13.7.2patchSee changes: drush-ops/drush@13.7.1...13.7.2
Release notes: https://github.com/drush-ops/drush/releases/tag/13.7.2
ergebnis/composer-normalize updated from
2.50.0to2.51.0minorSee changes: ergebnis/composer-normalize@2.50.0...2.51.0
Release notes: https://github.com/ergebnis/composer-normalize/releases/tag/2.51.0
ergebnis/json-pointer updated from
3.7.1to3.8.0minorSee changes: ergebnis/json-pointer@3.7.1...3.8.0
Release notes: https://github.com/ergebnis/json-pointer/releases/tag/3.8.0
justinrainbow/json-schema updated from
6.7.2to6.8.0minorSee changes: jsonrainbow/json-schema@v6.7.2...6.8.0
Release notes: https://github.com/jsonrainbow/json-schema/releases/tag/6.8.0
laravel/prompts updated from
0.3.14to0.3.16patchSee changes: laravel/prompts@v0.3.14...v0.3.16
Release notes: https://github.com/laravel/prompts/releases/tag/v0.3.16
maennchen/zipstream-php updated from
3.2.1to3.2.2patchSee changes: maennchen/ZipStream-PHP@3.2.1...3.2.2
Release notes: https://github.com/maennchen/ZipStream-PHP/releases/tag/3.2.2
mck89/peast updated from
1.17.4to1.17.5patchSee changes: mck89/peast@v1.17.4...v1.17.5
Release notes: https://github.com/mck89/peast/releases/tag/v1.17.5
mglaman/phpstan-drupal updated from
2.0.12to2.0.13patchSee changes: mglaman/phpstan-drupal@2.0.12...2.0.13
Release notes: https://github.com/mglaman/phpstan-drupal/releases/tag/2.0.13
openai-php/client updated from
0.19.0to0.19.1patchSee changes: openai-php/client@v0.19.0...v0.19.1
Release notes: https://github.com/openai-php/client/releases/tag/v0.19.1
phpdocumentor/reflection-docblock updated from
6.0.2to6.0.3patchSee changes: phpDocumentor/ReflectionDocBlock@6.0.2...6.0.3
Release notes: https://github.com/phpDocumentor/ReflectionDocBlock/releases/tag/6.0.3
phpspec/prophecy updated from
1.26.0to1.26.1patchSee changes: phpspec/prophecy@v1.26.0...v1.26.1
Release notes: https://github.com/phpspec/prophecy/releases/tag/v1.26.1
phpstan/phpstan updated from
2.1.44to2.1.49patchpsy/psysh updated from
0.12.21to0.12.22patchSee changes: bobthecow/psysh@v0.12.21...v0.12.22
Release notes: https://github.com/bobthecow/psysh/releases/tag/v0.12.22
rector/rector updated from
2.3.9to2.4.2minorSee changes: rectorphp/rector@2.3.9...2.4.2
Release notes: https://github.com/rectorphp/rector/releases/tag/2.4.2
slevomat/coding-standard updated from
8.28.0to8.28.1patchSee changes: slevomat/coding-standard@8.28.0...8.28.1
Release notes: https://github.com/slevomat/coding-standard/releases/tag/8.28.1
symfony/browser-kit updated from
7.4.4to7.4.8patchSee changes: symfony/browser-kit@v7.4.4...v7.4.8
Release notes: https://github.com/symfony/browser-kit/releases/tag/v7.4.8
symfony/config updated from
7.4.7to7.4.8patchSee changes: symfony/config@v7.4.7...v7.4.8
Release notes: https://github.com/symfony/config/releases/tag/v7.4.8
symfony/console updated from
7.4.7to7.4.8patchSee changes: symfony/console@v7.4.7...v7.4.8
Release notes: https://github.com/symfony/console/releases/tag/v7.4.8
symfony/css-selector updated from
7.4.6to7.4.8patchSee changes: symfony/css-selector@v7.4.6...v7.4.8
Release notes: https://github.com/symfony/css-selector/releases/tag/v7.4.8
symfony/dependency-injection updated from
7.4.7to7.4.8patchSee changes: symfony/dependency-injection@v7.4.7...v7.4.8
Release notes: https://github.com/symfony/dependency-injection/releases/tag/v7.4.8
symfony/dom-crawler updated from
7.4.6to7.4.8patchSee changes: symfony/dom-crawler@v7.4.6...v7.4.8
Release notes: https://github.com/symfony/dom-crawler/releases/tag/v7.4.8
symfony/error-handler updated from
7.4.4to7.4.8patchSee changes: symfony/error-handler@v7.4.4...v7.4.8
Release notes: https://github.com/symfony/error-handler/releases/tag/v7.4.8
symfony/event-dispatcher updated from
7.4.4to7.4.8patchSee changes: symfony/event-dispatcher@v7.4.4...v7.4.8
Release notes: https://github.com/symfony/event-dispatcher/releases/tag/v7.4.8
symfony/filesystem updated from
7.4.6to7.4.8patchSee changes: symfony/filesystem@v7.4.6...v7.4.8
Release notes: https://github.com/symfony/filesystem/releases/tag/v7.4.8
symfony/finder updated from
7.4.6to7.4.8patchSee changes: symfony/finder@v7.4.6...v7.4.8
Release notes: https://github.com/symfony/finder/releases/tag/v7.4.8
symfony/http-client updated from
6.4.34to6.4.36patchSee changes: symfony/http-client@v6.4.34...v6.4.36
Release notes: https://github.com/symfony/http-client/releases/tag/v6.4.36
symfony/http-foundation updated from
7.4.7to7.4.8patchSee changes: symfony/http-foundation@v7.4.7...v7.4.8
Release notes: https://github.com/symfony/http-foundation/releases/tag/v7.4.8
symfony/http-kernel updated from
7.4.7to7.4.8patchSee changes: symfony/http-kernel@v7.4.7...v7.4.8
Release notes: https://github.com/symfony/http-kernel/releases/tag/v7.4.8
symfony/mailer updated from
7.4.6to7.4.8patchSee changes: symfony/mailer@v7.4.6...v7.4.8
Release notes: https://github.com/symfony/mailer/releases/tag/v7.4.8
symfony/mime updated from
7.4.7to7.4.8patchSee changes: symfony/mime@v7.4.7...v7.4.8
Release notes: https://github.com/symfony/mime/releases/tag/v7.4.8
symfony/polyfill-php81 updated from
1.33.0to1.36.0minorSee changes: symfony/polyfill-php81@v1.33.0...v1.36.0
Release notes: https://github.com/symfony/polyfill-php81/releases/tag/v1.36.0
symfony/polyfill-php83 updated from
1.33.0to1.36.0minorSee changes: symfony/polyfill-php83@v1.33.0...v1.36.0
Release notes: https://github.com/symfony/polyfill-php83/releases/tag/v1.36.0
symfony/process updated from
7.4.5to7.4.8patchSee changes: symfony/process@v7.4.5...v7.4.8
Release notes: https://github.com/symfony/process/releases/tag/v7.4.8
symfony/psr-http-message-bridge updated from
7.4.4to7.4.8patchSee changes: symfony/psr-http-message-bridge@v7.4.4...v7.4.8
Release notes: https://github.com/symfony/psr-http-message-bridge/releases/tag/v7.4.8
symfony/routing updated from
7.4.6to7.4.8patchSee changes: symfony/routing@v7.4.6...v7.4.8
Release notes: https://github.com/symfony/routing/releases/tag/v7.4.8
symfony/serializer updated from
7.4.7to7.4.8patchSee changes: symfony/serializer@v7.4.7...v7.4.8
Release notes: https://github.com/symfony/serializer/releases/tag/v7.4.8
symfony/string updated from
7.4.6to7.4.8patchSee changes: symfony/string@v7.4.6...v7.4.8
Release notes: https://github.com/symfony/string/releases/tag/v7.4.8
symfony/translation updated from
7.4.6to7.4.8patchSee changes: symfony/translation@v7.4.6...v7.4.8
Release notes: https://github.com/symfony/translation/releases/tag/v7.4.8
symfony/validator updated from
7.4.7to7.4.8patchSee changes: symfony/validator@v7.4.7...v7.4.8
Release notes: https://github.com/symfony/validator/releases/tag/v7.4.8
symfony/var-dumper updated from
7.4.6to7.4.8patchSee changes: symfony/var-dumper@v7.4.6...v7.4.8
Release notes: https://github.com/symfony/var-dumper/releases/tag/v7.4.8
symfony/var-exporter updated from
7.4.0to7.4.8patchSee changes: symfony/var-exporter@v7.4.0...v7.4.8
Release notes: https://github.com/symfony/var-exporter/releases/tag/v7.4.8
symfony/yaml updated from
7.4.6to7.4.8patchSee changes: symfony/yaml@v7.4.6...v7.4.8
Release notes: https://github.com/symfony/yaml/releases/tag/v7.4.8
webmozart/assert updated from
2.1.6to2.3.0minorSee changes: webmozarts/assert@2.1.6...2.3.0
Release notes: https://github.com/webmozarts/assert/releases/tag/2.3.0
Summary by CodeRabbit
Chores
Configuration