Feature #3304 power_spectra - #3411
Open
JohnHalleyGotway wants to merge 113 commits into
Open
Conversation
…plenty of work to do on this.
…e the Grid-Diag docs.
…rm with Gerard.
…rInfo base class.
…d, used a pre-defined hard-coded list of variable names to drive the derivation logic.
…class. Next up are handling wind rotations and adding lots of tests.
…add long names and units for derived wind fields.
…ing winds, the level string needs to be wrapped in parenthesis based on the existing parsing logic.
…r than just the derived classes for GRIB1 and GRIB2.
…nce. Still need to add the vorticity and divergence derivations and add new unit tests.
… they're non-trivial.
… value rather than erroring out with an unset grid in the parse_vx_grid() function. Also remove an uneccessary warning.
22 tasks
22 tasks
22 tasks
…alues from the first bin (e.g. =0) and also omit points beyond the square domain.
…e logic for using GSL's FFT algorithm to compute a DCT. In particular, dct_typeII_1d() correctly unpacks the half-complex output thats returned by gsl_fft_real_transform().
…at's the only place its used.
JohnHalleyGotway
marked this pull request as ready for review
August 27, 2026 22:58
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



After many iterations, Grid-Diag now replicates the output from the reference

KE_Spectra_Calculation_Plotcode using the same sample data.Note that the link checker automated test will still fail until @jprestop is able to address the broken links in the documentation.
Expected Differences
If yes, please describe:
In the Grid-Diag configuration file, the
power_spectrumdictionary andoutput_flag.power_spectrumboolean are both new:If yes, please describe:
Adds new NetCDF variables and dimensions to the Grid-Diag output file, as noted in this grid_diag Output File section and in the Output format changes portion of the Upgrade Instructions.
Pull Request Testing
Describe testing already performed for these changes:
Ran Grid-Diag many times to achieve the result shown above replicating the functionality of the existing Python code.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Please find this feature branch compiled and available for testing in the following locations:
seneca:/d1/projects/MET/MET_pull_requests/met-13.0.0/rc1/MET-feature_3304_power_spectra/bin/grid_diag.ursa:/scratch3/BMC/dtc/John.H.Gotway/METplus/development/MET-feature_3304_power_spectra/bin/grid_diag.Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
I updated the Grid-Diag documentation and upgrade instructions. Please review and advise whether more detail should be added.
Do these changes include sufficient testing updates? [Yes]
I added two new tests to
unit_grid_diag.xml, one for wind speed and one for kinetic energy. Note that evaluating kinetic energy (KENG) is what triggers the logic to diff the U and V components separately.Will this PR result in changes to the MET test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
Modifies 4 existing output files:
Adds 6 new output files:
Will this PR result in changes to existing METplus Use Cases? [Yes]
If yes, create a new Update Truth METplus issue to describe them.
Do these changes introduce new SonarQube findings? [Yes or No]
If yes, please describe:
Reduces the overall number of findings from 13,426 in
developto 13,362 in this feature branch.Please complete this pull request review by [During the week of 8/31 - 9/4].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release