Update main_v12.2-ref after #3410 - #3423
Open
github-actions[bot] wants to merge 46 commits into
Open
Conversation
* Per dtcenter/METplus-Internal#64, initial attempt * Per dtcenter/METplus-Internal#63, update syntax * Per dtcenter/METplus-Internal#63, update syntax * Per dtcenter/METplus-Internal#63, update syntax * Per dtcenter/METplus-Internal#63, update syntax * Per dtcenter/METplus-Internal#63, update syntax * Per dtcenter/METplus-Internal#63, update syntax * Add continuous integration docs * Fix docs
* Per #3253, address 4 medium severity SonarQube reliability issues. * Per #3253, make ConcatString compile. * Per #3253, address TCPolyArray Reliability SQ issue. * Per #3253, switch conv_data from dynamically allocated memory to an STL vector. * Per #3253, switch from dynamically allocated CTSInfo and VL1L2Info arrays to using vectors to address SQ reliability findings. * Per #3253, update TrackPairInfoArray to switch from dynamically allocated memory to using an STL vector. * Per #3253, correct PCTInfo memory leak. * Per #3253, update ColorTable class to switch from dynamically allocated memory to STL vectors. * Per #3253, update crr_array.h to switch from dynamically allocated memory to using an STL vector. * Per #3253, delete crr_array.h and replace it's use in engine.h/.cc with STL vectors. * Per #3253, more SonarQube cleanup. * Per #2353, fix const auto to const auto & references to solve SQ issues. * Per #3253, try to solve my_config_scanner.cc issue. * Per #3253, attempt to fix idstack.cc SQ issue. * Saving verison that compiles and runs well. * Per #3253, simplify structure of idstack.h/.cc to operate on vectors of strings rather than using the unnecessary Identifier class. * Couple more tweaks. * Update idstack.cc * Per #3253, fix several for loops to iterate over references to the actual elements rather than copies of them. * Per #3253, correct ColorTable::clear() function which failed to call Entry.clear().
* Per #3258, provide default lapse rate values in ConfigConstants as the average enviromental lapse rate rather than adiabatic lapse rates. By default, set lapse_rate_correction.value = NA and prompt the user to specify an appropriate setting. * Per #3258, add error check to ensure that the lapse rate correction value has been specified well, when needed. * Per #3258, update Point-Stat and Ensemble-Stat config files to explicitly specify the lapse rate values when verifying TMP/Z2 and DPT/Z2. * Per #3258, make log messages more transparent and clear. * Per #3258, update lapse_rate_correction documentation * Per #3258, remove verifying DPT from the Ensemble-Stat unit test since the input ensemble data does not contain DPT/Z2. * Update docs/Users_Guide/config_options.rst Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> --------- Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
* Per #3255, update the shift_right logic to only shift the grid after reading data and processing any set_attr_grid setting first. * Per #3255, add GridShifted to Met2dDataFile to make ensure that we only shift the grid definition to the right one time. Without tracking that, multiple calls to data_plane() could shift the grid multiple times. * Per #3255, check for null pointer to fix SonarQube reliability issue. * Update data_class.cc to fix SonarQube reliability issue. * Per #3255, reduce a few more SonarQube maintainability issues. * Per #3255, revert changes in mode_exec.cc that are not required to solve this issue.
* Per #3258, provide default lapse rate values in ConfigConstants as the average enviromental lapse rate rather than adiabatic lapse rates. By default, set lapse_rate_correction.value = NA and prompt the user to specify an appropriate setting. * Per #3258, add error check to ensure that the lapse rate correction value has been specified well, when needed. * Per #3258, update Point-Stat and Ensemble-Stat config files to explicitly specify the lapse rate values when verifying TMP/Z2 and DPT/Z2. * Per #3258, make log messages more transparent and clear. * Per #3258, update lapse_rate_correction documentation * Per #3258, remove verifying DPT from the Ensemble-Stat unit test since the input ensemble data does not contain DPT/Z2. * Update docs/Users_Guide/config_options.rst Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> * Per #3258, add skip_missing entry to the lapse_rate_correction and msl_agl_conversion dictionaries in the Point-Stat and Ensemble-Stat config files to skip pairs with bad topography or observation elevations. * Per #3258, update the vx_config and vx_util libraries to parse the new skip_missing config options. * Tweak user's guide wording. * Per #3270, delete accidental commits. * Per #3270, update VxPairBase::correct_lapse_rate(...) and convert_msl_agl(...) to return booleans to alert the caller about problems applying the correction or conversion. * Per #3270, update VxPairDataPoint::add_point_obs(...) to check the updated return status and skip_missing configuration option. * Per #3270, remove the skip_missing configuration option. * Per #3270, updates * Per #3270, update the Ensemble-Stat unit test to demonstrate a point observation with bad elevation values. * Per #3270, minor changes to fix easy SonarQube maintainabiliy issues in pair_data_point.h/.cc and pair_data_ensemble.h/.cc. * Per #3270, fix initialization order * Initialize n_pair member variable. --------- Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
* Per #3278, update all MET usage statements to support an integer exit_code argument. Update the CommandLine class to check for the -help/--help options and run usage with exit_code = 0. Otherwise, default to exit_code = 1. Note that CommandLine also exits with 0 on -version/--version. Had to update usage statement logic in MODE and add usage of the CommandLine class to a couple of utilities. * Per #3278, add ascii2nc unit tests to demonstrate bad status when run with no arguments and good status when run with -help. * Per #3278, fix up call to gen_climo_bin usage statement. * Per #3278, need to call CommandLine::allow_unrecognized_switches() after the set function. * Per #3278, update Note to include details about the return status. * Per #3278, consistently use __attribute__((noreturn)) and static in the definition of the usage() statement in all the MET application code to drive down the number of SonarQube maintainability issues. * Add static attribute to usage functions * Change static functions to global in mode_usage.cc --------- Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
* Per #3072, add constants and logic to process the message_typ_group_map entries for LAPSERT and MSLAGL to specify the message types for which the lase_rate_correction and msl_agl_conversion should apply. * Per #3072, update PairDataPoint and PairDataEnsemble to check the new msg_typ_lapsert and msg_typ_mslagl settings. * Per #3072, update Point-Stat and Ensemble-Stat to use common functionality in PairBase to parse the specialized msg_typ_group_map entries. Since the common library code uses default values, we do not need to error out if the expected entries are missing. * Per #3270, update the message_type_group_map dictionary in Point-Stat and Ensemble-Stat config file to include entries for LAPSERT and MSLAGL. * Per #3270, update documentation. * Per #3270, fix typo and accessor function. * Per #3270, fix pair_data_ensemble.cc logic. * Per #3270, tweak docs. * Per #3270, clarify docs further. * Update config_options.rst Adding a word --------- Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>
* Per #3207, update convert_msl_agl() and correct_lapse_rate() functions to include the station name and point observation summary string as arguments to enhance the log messages. * Per #3207, update calls to convert_msl_agl() and correct_lapse_rate() in PairDataPoint and PairDataEnsemble. In PairDataPoint, operate on a copy of the obs value rather than the original input one to avoid applying the same operation multiple times. * Per #3072, update the criteria in pair_data_ensemble.cc to refine when correct_lapse_rate() and convert_msll_agl() are called. There is not a problem with the output, but the current logic produces confusing and unexpected log messages. * Per #3270, revise logging and logic for Ensemble-Stat. --------- Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
* Per #3287, update log message to indicate that the observation height is printed rather than the station elevation. * Per #3287, update versio info in MET User's Guide. * Per #3287, update version numbers in MET config files. * Per #3287, add 12.2 to list of versions to be build by the release docker images workflow. * Per #3287, update 12.2.0 release notes.
…n embedding for Stat-Analysis.
…fter the release-docker-images.yml workflow failed after running out of disk space.
…g artifacts so that they are available even if the scan fails
Updated library paths to point to lib64 directory.
…e so that the user-specified set_attr_grid setting takes effect. (#3300)
* Per #3348, update MET_PYTHON settings, update to version 12.2.1, and add release notes. * Per #3348, MET_PYTHON is not actually required by build_met_docker.sh * Per #3342, parse and apply the file_type option from the -field string when searching for input files to sum. * Revert "Per #3342, parse and apply the file_type option from the -field string when searching for input files to sum." This reverts commit 141660d.
* Per #3348, update MET_PYTHON settings, update to version 12.2.1, and add release notes. * Per #3348, MET_PYTHON is not actually required by build_met_docker.sh * Per #3342, parse and apply the file_type option from the -field string when searching for input files to sum. * Revert "Per #3342, parse and apply the file_type option from the -field string when searching for input files to sum." This reverts commit 141660d. * Per #3342, parse and apply the file_type option from the -field string when searching for input files to sum. * Per #3353, add this issue the v12.2.1 release notes. * Per #3353, fix issue number in comments.
* Per #3359, update the OpenMP shared statements to remove constant variables which were causing compilation errors. With these changes, MET version 12.2.1 does compile and run on the CCS AWS instance. * Per #3359, for GNU 8.5.0 I removed the constant variables from the OpenMP shared list. But with default(none), that causes a compilation error for GNU 12.2.0. Switching default(none) to default(shared) should satisfy both GNU 8.5.0 and 12.2.0.
* Per #3362, update compute_aggregated_seeps_grid() to store the forecast timing info in the SEEPS output fields. * hotfix: fix broken copy of diff files needed after changes to diff_util output * Per #3362, update version of actions to get passed Node.js 20 warnings from GHA. * Per #3362, do still need to use upload-artifact/merge@7 * Update Docker image scanning action to version 2 --------- Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
* Per #3374, update nc_cf_file.cc to apply false_easting and false_northing offsets. Also include an OpenMP patch when compiling on casper. * Per #3374, update comp_dir.py to ignore a small recurring difference in the ALAL2010_stat.out file. --------- Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated initial_time at ugrid_data/mpas/diag.2012-04-09_12.00.00_reduced.nc
Created by @hsoh-u