Bugfix #3410 ugrid lead time develop - #3425
Open
hsoh-u wants to merge 15 commits into
Open
Conversation
added 12 commits
July 29, 2026 20:22
23 tasks
DanielAdriaansen
requested changes
Aug 25, 2026
DanielAdriaansen
left a comment
Contributor
There was a problem hiding this comment.
Same changes as in #3424
Contributor
|
@hsoh-u I also suggest we update the MPAS test data for the UGRID capability as part of this PR. Could you try running the unit tests with this file on Seneca?
Here is the static file: |
Co-authored-by: Dan Adriaansen <dadriaan@ucar.edu>
Co-authored-by: Dan Adriaansen <dadriaan@ucar.edu>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Expected Differences
The
init_hour(orlead_time) is computed.time variablehas the unitsminutes/hours since YYYY-MM-DD, setsinit_timefrom the units attribute.init_time variableis configured at the UGrid configurations, read theinit_time variableand sets oroverrideinit_timeAs a result, the 7 output file names were changed from
*_000000_*to_120000_because init_hour 00 was changed to 12. TheFCST_LEADcolumn at the output files were changed too.The unit.py was updated to handle missing output files and initialized the result object to None
Refactored
UGridFile::open_metadata()atugrid_file.ccand separated two APIs:metadata_coord_variables()andmetadata_time().Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
by unit test
The binary files are available at seneca:/d1/personal/hsoh/git/pull_request/MET_bugfix_3410_ugrid_lead_time_develop/share/met
Note:
/d1/personal/hsoh/git/pull_request/MET_bugfix_3410_ugrid_lead_time_develop/share/met/config/UGridConfig_mpasshould be applied to compute lead_hour (to read the initial_time variable).Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [No]
The tests themselves were not updated, but the existing tests are now producing different outputs — specifically, the file name and init_hour columns differ across the 7 files.
If yes, describe the new output and/or changes to the existing output:
The output file names are different (from 000000 to 120000). The values in the
init_hourcolumns have also changed.If yes, create a new Update Truth METplus issue to describe them.
The output file names changed from 000000 to 120000. If these are used as input for the test cases, the expected input files may no longer exist. The values in the
init_hourcolumns have also changed.Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release