Feature #3335 point_weight_flag - #3427
Open
JohnHalleyGotway wants to merge 41 commits into
Open
Conversation
…Guide and config file for Point-Stat and Ensemble-Stat.
…_weight_flag = KDE option and update unit_point_weight.xml to test out the new option.
… calls compute_kde_weights() if they've not already been computed.
…us functionality.
…ncern with exactly how the weights are computed.
…t_weights.txt output ASCII files.
…gitude difference no larger than 180 degrees.
…tions.yml since testing the compilation options on released versions has proven sufficient. I don't see a need to also test routinely through cron.
… replicate previous outputs #ci-run-unit
…mpute_kde_weights() to call it when computing the angle from the center of the earth to the two lat/lon points on the surface.
…av.cc, the library linking order should now be -lvx_util -lvx_nav.
…message to avoid dividing by zero.
22 tasks
… difference to provide a numeric reference.
…rvations and update ensemble stat to write out the point weights.
23 tasks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Expected Differences
This PR adds the
point_weight_flag = KDEconfiguration option for Point-Stat, Ensemble-Stat, and Pair-Stat.Differences are flagged in 115, which is a whole lot! But most are very minor. I'll describe them below:
[68] Minor config file diffs in
internal/test_unit,data/config, andscripts/configadding the new options or modifying whitespace.[18] Changes to
Makefile.amandMakefile.into compile the new code or due to-lvx_utilnow depending on-lvx_nav.[4] Documentation updates in
.rstfiles.[9] Updates to
point_stat(3),ensemble_stat(3), andpair_stat(3) source code to parse and apply the new options.[3] Update the
vx_configlibrary to parse the new options.[2] Update the
vx_navlibrary to compute thegc_angle()between two lat/lon points.[3] Update the
vx_utillibrary to compute KDE point weights.[6] Update the
vx_statisticslibrary to apply the KDE point weights.[1] Update
unit_point_weight.xmlto 3 add new tests.[1] Update the
compilation_options.ymlworkflow to remove unnecessary comments.Do these changes introduce new tools, command line arguments, or configuration file options? [Yes]
If yes, please describe:
Adds 1 new configuration value to enable this logic:
Adds 2 new configuration options to configure the KDE point weights:
If yes, please describe:
When
write_weights = TRUE;a new ASCII output file is written to dump the computed weight values.Pull Request Testing
Describe testing already performed for these changes:
In
unit_point_weight.xml, I added 2 new calls to Point-Stat and one new call to Ensemble-Stat to demonstrate this logic. Also see the testing described in this issue comment for details.Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Briefly review code changes.
Carefully review documentation updates on RTD (https://metplus--3427.org.readthedocs.build/projects/met/en/3427/?readthedocs-diff=true&readthedocs-diff-chunk=1)
Inspect changes and additions to the unit test output.
Please find this code compiled as the
met_testuser inseneca:/d1/projects/MET/MET_pull_requests/met-13.0.0/rc1/MET-feature_3335_point_weight_flag.Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the MET test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
Note that the link checker test will fail because issue #3416 has not been completed yet.
Will this PR result in changes to existing METplus Use Cases? [No]
If yes, create a new Update Truth METplus issue to describe them.
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
While some existing issues are flagged, the overall number of findings is reduced slightly from 13,426 in develop to 13,381 for this pull request.
Please complete this pull request review by [Monday Aug 31, 2026].
Recommend that we review this PR with @mpm-meto when we meet on Aug 27, 2026.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release