Skip to content

Bugfix #3429 develop obs_error_table_lookup - #3431

Open
JohnHalleyGotway wants to merge 4 commits into
developfrom
bugfix_3429_develop_obs_error_table_lookup
Open

Bugfix #3429 develop obs_error_table_lookup#3431
JohnHalleyGotway wants to merge 4 commits into
developfrom
bugfix_3429_develop_obs_error_table_lookup

Conversation

@JohnHalleyGotway

Copy link
Copy Markdown
Collaborator

These are the same changes as PR #3430, but for the develop branch instead. Also note that this adds a new unit test to demonstrate the bad observation error table lookup. This is accomplished by truncated the default obs_error_table.txt file to only include the first APCP entry for values between 0 and 0.1. All APCP_24 precip observations outside of this range are excluded from the output of that new test.

Please review this at the same time as #3430, and note the following:

  • Find the branch available for testing in seneca:/d1/projects/MET/MET_pull_requests/met-13.0.0/rc1/MET-bugfix_3429_develop_obs_error_table_lookup.
  • The following new output test files are created:
ensemble_stat/ensemble_stat_OBSERR_BAD_LOOKUP_20120410_120000V_ecnt.txt
ensemble_stat/ensemble_stat_OBSERR_BAD_LOOKUP_20120410_120000V_orank.nc
ensemble_stat/ensemble_stat_OBSERR_BAD_LOOKUP_20120410_120000V_orank.txt
ensemble_stat/ensemble_stat_OBSERR_BAD_LOOKUP_20120410_120000V_phist.txt
ensemble_stat/ensemble_stat_OBSERR_BAD_LOOKUP_20120410_120000V_relp.txt
ensemble_stat/ensemble_stat_OBSERR_BAD_LOOKUP_20120410_120000V_rhist.txt
ensemble_stat/ensemble_stat_OBSERR_BAD_LOOKUP_20120410_120000V_ssvar.txt
ensemble_stat/ensemble_stat_OBSERR_BAD_LOOKUP_20120410_120000V.stat
  • Compare ensemble_stat/ensemble_stat_OBSERR_20120410_120000V_ecnt.txt to ensemble_stat/ensemble_stat_OBSERR_BAD_LOOKUP_20120410_120000V_ecnt.txt and note that it has fewer lines since there are no pairs for OBS_THRESH = >=2.54 and fewer for OBS_THRESH = >0. As expected, the number of matched pairs in the TOTAL column are greatly reduced for APCP_24 but remain constant for TMP, to which observation error is NOT applied.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In review

Development

Successfully merging this pull request may close these issues.

Bugfix: Fix Ensemble-Stat to skip observations when the observation error table lookup fails

1 participant