Bugfix #3429 develop obs_error_table_lookup - #3431
Open
JohnHalleyGotway wants to merge 4 commits into
Open
Conversation
…_stat to skip over observations when the observation error table lookup fails to find a matching entry.
…d observation error table lookups.
Closed
23 tasks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



These are the same changes as PR #3430, but for the
developbranch instead. Also note that this adds a new unit test to demonstrate the bad observation error table lookup. This is accomplished by truncated the defaultobs_error_table.txtfile to only include the firstAPCPentry for values between 0 and 0.1. AllAPCP_24precip observations outside of this range are excluded from the output of that new test.Please review this at the same time as #3430, and note the following:
seneca:/d1/projects/MET/MET_pull_requests/met-13.0.0/rc1/MET-bugfix_3429_develop_obs_error_table_lookup.ensemble_stat/ensemble_stat_OBSERR_20120410_120000V_ecnt.txttoensemble_stat/ensemble_stat_OBSERR_BAD_LOOKUP_20120410_120000V_ecnt.txtand note that it has fewer lines since there are no pairs forOBS_THRESH = >=2.54and fewer forOBS_THRESH = >0. As expected, the number of matched pairs in theTOTALcolumn are greatly reduced forAPCP_24but remain constant forTMP, to which observation error is NOT applied.