Feature #3407 Update METbaseimage version to 13.0 - #3435
Conversation
…eg fault has been resolved
… treated like a number and truncating the .0
…s.sh as well as the SonarQube and Build Docker/Trigger METplus workflows. Haven't tested directly yet. I'll let the PR test for me.
…erfile and change them to required arguments.
…so just remove the defaults to we don't need to maintain them.
|
JohnHalleyGotway
left a comment
There was a problem hiding this comment.
@georgemccabe, as recommended in the PR, I update the logic to define the MET base repo and tag in a single location, a new script named get_met_base_image.sh.
The logic is factored out of the existing set_job_controls.sh script.
Please take a look to see if you're comfortable with this change.
|
@JohnHalleyGotway, the changes you made to consolidate the base image version is great! Thank you for doing that. There are a few things that I think should be done with these changes.
|
|
@JohnHalleyGotway, a couple other suggestions/thoughts:
|



...after the TCDiag seg fault has been resolved
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Ran MET testing workflow with Docker image created from METbaseimage branch and confirmed all tests, including the TCDiag test that was failing), are now passing
https://github.com/dtcenter/MET/actions/runs/33523420631
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the MET test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Will this PR result in changes to existing METplus Use Cases? [No]
If yes, create a new Update Truth METplus issue to describe them.
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by 9/4/2026.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release