Skip to content

Add hash implementation to scalar - #127

Merged
HDauven merged 2 commits into
masterfrom
scalar-hash-equality
Oct 30, 2023
Merged

Add hash implementation to scalar#127
HDauven merged 2 commits into
masterfrom
scalar-hash-equality

Conversation

@HDauven

@HDauven HDauven commented Oct 27, 2023

Copy link
Copy Markdown
Member

Resolves #106

@HDauven
HDauven requested a review from moCello October 27, 2023 23:26
@HDauven HDauven changed the title Scalar hash equality Add hash implementation to scalar Oct 27, 2023

@moCello moCello left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small suggestion

Comment thread src/scalar.rs Outdated
Comment thread src/scalar.rs Outdated
@HDauven
HDauven force-pushed the scalar-hash-equality branch from 7da9faf to 6b5716c Compare October 30, 2023 12:29
@HDauven

HDauven commented Oct 30, 2023

Copy link
Copy Markdown
Member Author

small suggestion

As per your suggestion, moved the implementation to scalar/dusk.rs.

As a side effect, the Hash import and Hash derive, which doesn't exist upstream, could be removed in the scalar.rs file as well.

There's an issue open upstream here that would implement the same. If it gets accepted there, we can remove our own implementation.

@moCello moCello left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HDauven
HDauven merged commit 3ebde2e into master Oct 30, 2023
@HDauven
HDauven deleted the scalar-hash-equality branch October 30, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scalar derives Hash but explicitly implements PartialEq

2 participants