feat(debug-console): integrate dxscript code editor and align chart c…#35
Open
antonio-pedro99 wants to merge 5 commits into
Open
Conversation
…omponents with dxscript/dxlink-dxcharts-lite - Replace @devexperts/dxcharts-lite with @dxscript/dxlink-dxcharts-lite for chart rendering - Integrate @dxscript/dxlink-dxscript-editor for script editing with samples and error display - Refactor CandlesChannelManager and ScriptCandlesChannelManager to use IndiChart and IndiChartHandle - Simplify indicator data handling and chart updates - Remove legacy JSIcon and AceEditor code - Update dependencies and lockfile accordingly
Fyzu
reviewed
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the charting and code editor integration in the
dxlink-docspackage to use new, specialized packages for chart and editor functionality. It removes direct dependencies on@devexperts/dxcharts-liteand Ace editor, replacing them with@dxscript/dxlink-dxcharts-liteand@dxscript/dxlink-dxscript-editor. The chart rendering logic in the debug console is updated to leverage the new chart API, simplifying the code and improving maintainability. Several files related to the old Ace editor integration, chart configuration, and code completions are removed.Dependency and Integration Updates:
@devexperts/dxcharts-lite,ace-builds, andreact-aceto@dxscript/dxlink-dxcharts-liteand@dxscript/dxlink-dxscript-editorinpackage.json, and removed@dxscript/js-samples.@dxscript/dxlink-dxcharts-lite/styles.cssto ensure correct chart styling.Chart Rendering Refactor:
CandlesChannelManagerandscript-candles-channel-managerto use the newIndiChartcomponent and its API, removing manual chart creation, color configuration, and direct DOM manipulation. Chart data is now pushed via the new API, and error handling is added. [1] [2] [3] [4]Code Cleanup and Removal:
Removed the custom Ace editor mode integration and code completions for dxscript, as well as the chart color configuration file, since these are now handled by the new editor and chart packages. [1] [2] [3]
Removed the unused
JSIconcomponent from the debug console icons.…omponents with dxscript/dxlink-dxcharts-liteReplace @devexperts/dxcharts-lite with @dxscript/dxlink-dxcharts-lite for chart rendering
Integrate @dxscript/dxlink-dxscript-editor for script editing with samples and error display
Refactor CandlesChannelManager and ScriptCandlesChannelManager to use IndiChart and IndiChartHandle
Simplify indicator data handling and chart updates
Remove legacy JSIcon and AceEditor code
Update dependencies and lockfile accordingly
Fixes #32