Skip to content
This repository was archived by the owner on Oct 6, 2022. It is now read-only.

weth-pusd constants #63

Open
samweinberg23 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

weth-pusd constants #63

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e0752a
weth-pusd constants
samweinberg23 Jul 30, 2020
27bed54
fix
samweinberg23 Jul 30, 2020
cd944cf
fix2
samweinberg23 Jul 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions dydx/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
PAIR_WETH_USDC = 'WETH-USDC'
PAIR_DAI_USDC = 'DAI-USDC'
PAIR_PBTC_USDC = 'PBTC-USDC'
PAIR_WETH_PUSD = 'WETH_PUSD'

DECIMALS_WETH = 18
DECIMALS_SAI = 18
Expand All @@ -57,12 +58,15 @@
SMALL_TRADE_SIZE_DAI = 10000 * (10 ** DECIMALS_DAI)
SMALL_TRADE_SIZE_PBTC = 0.5 * (10 ** DECIMALS_PBTC)
FEE_SMALL_WETH = Decimal(100) * FROM_BIPS
FEE_LARGE_WETH = Decimal(15) * FROM_BIPS
FEE_LARGE_WETH = Decimal(100) * FROM_BIPS
FEE_SMALL_DAI = Decimal(100) * FROM_BIPS
FEE_LARGE_DAI = Decimal(5) * FROM_BIPS
FEE_LARGE_PBTC = Decimal(7.5) * FROM_BIPS
FEE_SMALL_PBTC = Decimal(50) * FROM_BIPS
FEE_MAKER_PBTC = Decimal(-2.5) * FROM_BIPS
FEE_LARGE_DAI = Decimal(100) * FROM_BIPS
FEE_LARGE_PBTC = Decimal(100) * FROM_BIPS
FEE_SMALL_PBTC = Decimal(100) * FROM_BIPS
FEE_MAKER_PBTC = Decimal(100) * FROM_BIPS
FEE_LARGE_WETH_PUSD = Decimal(100) * FROM_BIPS
FEE_SMALL_WETH_PUSD = Decimal(100) * FROM_BIPS
FEE_MAKER_WETH_PUSD = Decimal(100) * FROM_BIPS

@BrendanChou BrendanChou Jul 30, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new variables are never used, instead you can modify the get_limit_fee() function

FEE_ZERO = Decimal(0)

# ------------ Transaction Constants ------------
Expand Down
2 changes: 1 addition & 1 deletion tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def _additional_matcher(request):
assert order['amount'] == str(args['amount'])
assert order['limitPrice'] == str(args['limitPrice'])
assert order['triggerPrice'] == '0'
assert order['limitFee'] == '0.00075'
assert order['limitFee'] == '0.01'
assert order['maker'] == client.public_address
assert order['taker'] == consts.TAKER_ACCOUNT_OWNER
assert abs(
Expand Down