feat: add createDrop() and ingestDrop() methods to Store.#358
Open
zicklag wants to merge 1 commit into
Open
Conversation
Author
|
This is untested so far, thus the draft state. I'll try to add a test, and also probably test in my project. |
zicklag
force-pushed
the
feat/createIngestDrop
branch
from
08f3033 to
fb8565d
Compare
Author
|
Created a test case that is failing currently but passes after a fix in Willow: earthstar-project/willow-js#38. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem you solved?
I needed a way to take advantage of Willow's Sideloading protocol, which was not possible to do in Earthstar without modifications since the Willow schemes are private.
What solution are you recommending?
I think that simply adding
createDrop()andingestDrop()methods should give me the functionality I need.