Skip to content

Ignore OP_UNDEF when JITing similar to interpreter and original quake3 #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krsh732 wants to merge 1 commit into from
Closed

Ignore OP_UNDEF when JITing similar to interpreter and original quake3 #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions code/qcommon/vm_aarch64.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1681,9 +1681,6 @@ qboolean VM_Compile( vm_t *vm, vmHeader_t *header )
switch ( ci->op )
{
case OP_UNDEF:
emit( BRK( 0 ) );
break;

case OP_IGNORE:
ip += ci->value;
break;
Expand Down
3 changes: 0 additions & 3 deletions code/qcommon/vm_armv7l.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1296,9 +1296,6 @@ qboolean VM_Compile( vm_t *vm, vmHeader_t *header )
switch ( ci->op )
{
case OP_UNDEF:
emit(BKPT(1));
break;

case OP_IGNORE:
ip += ci->value;
break;
Expand Down
2 changes: 1 addition & 1 deletion code/qcommon/vm_interpreted.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ int VM_CallInterpreted2( vm_t *vm, int nargs, int32_t *args ) {
ci++;

switch ( opcode ) {

case OP_UNDEF:
case OP_IGNORE:
ci += v0;
goto nextInstruction2;
Expand Down
3 changes: 0 additions & 3 deletions code/qcommon/vm_powerpc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1893,9 +1893,6 @@ qboolean VM_Compile( vm_t *vm, vmHeader_t *header )
switch ( ci->op )
{
case OP_UNDEF:
emit( PPC_TRAP() );
break;

case OP_IGNORE:
ip += ci->value;
break;
Expand Down
3 changes: 0 additions & 3 deletions code/qcommon/vm_x86.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2913,9 +2913,6 @@ qboolean VM_Compile( vm_t *vm, vmHeader_t *header ) {
switch ( ci->op ) {

case OP_UNDEF:
emit_brk(); // int 3
break;

case OP_IGNORE:
ip += ci->value;
break;
Expand Down