improvement: bump CVAR desc limit from 256 to 8192 - #419
Open
WofWca wants to merge 1 commit into
Open
Conversation
256 is quite short, and we bump our head against it already in the baseq3a mod: https://github.com/ec-/baseq3a/pull/84. Note that this does not increase memory usage if no CVAR description is longer than 256. (side note: maybe it'd be better if we didn't copy the string at all and just used the original pointer, because CVAR descriptions are usually string literals which don't ever change).
Owner
|
This is fine, thank you, but reduce limit to 1024/ |
Author
As a mod developer I agree that 1k+ is probably too much, but here we're talking about an engine. If there is some crazy mod that for whatever reason needs more, why not let them? Especially that it costs us nothing - we use only as much memory as the description needs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
256 is quite short, and we bump our head against it already
in the baseq3a mod:
https://github.com/ec-/baseq3a/pull/84.
Note that this does not increase memory usage
if no CVAR description is longer than 256.
(side note: maybe it'd be better
if we didn't copy the string at all and just used the original pointer,
because CVAR descriptions are usually string literals
which don't ever change).