Show quick fix to rename references for modifying symbol name manually#2487
Open
CsCherrYY wants to merge 1 commit intoeclipse-jdtls:mainfrom
Open
Show quick fix to rename references for modifying symbol name manually#2487CsCherrYY wants to merge 1 commit intoeclipse-jdtls:mainfrom
CsCherrYY wants to merge 1 commit intoeclipse-jdtls:mainfrom
Conversation
CsCherrYY
force-pushed
the
cs-rename-reference
branch
from
83d814d to
d44be6e
Compare
Contributor
Author
|
Tested in spring-petclinic Owner.java, some performance profiling result: Most calculation of this change presents in method When most changes focus on editing code: |
Contributor
Author
|
tested in a java file with ~200 public fields and focus more on editing member names:
tested in a java file with ~150 public methods and focus on both editing the method name and method content
The performance recording shows the performance is acceptable. |
CsCherrYY
force-pushed
the
cs-rename-reference
branch
from
d44be6e to
dd96acb
Compare
Contributor
|
test this please |
CsCherrYY
requested review from
fbricon,
jdneo,
rgrunber,
snjeza and
testforstephen
Signed-off-by: Shi Chen <chenshi@microsoft.com>
CsCherrYY
force-pushed
the
cs-rename-reference
branch
from
dd96acb to
f963941
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to redhat-developer/vscode-java#2959, more details and demo video can be found there.
Will add test cases later.