Skip to content

adds quevee action to deploy action #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eriksven wants to merge 4 commits into
base: main
Choose a base branch
from
Open

adds quevee action to deploy action #16

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d92fb1
adds quevee action to deploy action
eriksven Jun 27, 2025
0edbf1e
removes whitespaces
eriksven Jun 30, 2025
3dfd9db
adapts references in deploy_crate action because quevee action automa…
eriksven Sep 18, 2025
710c23a
removes reference to test action in quevee action as this should rath…
eriksven Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/deploy_crate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,22 @@ jobs:
env:
CARGO_REGISTRY_TOKEN: ${{ secrets.CRATES_API_TOKEN }}
run: cargo publish -p kuksa-rust-sdk

- name: Collect quality artifacts
uses: eclipse-dash/quevee@v1
id: quevee
with:
release_url: ${{ github.event.release.html_url }}
artifacts_readme: README.md
artifacts_requirements:
artifacts_testing: .github/actions/run-lib-tests/action.yml

@sophokles73 sophokles73 Sep 19, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the idea here is to point to an artifact that actually contains the results of running the tests, e.g. a junit test report

@eriksven eriksven Sep 19, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I removed the testing entry for now. WDYT?

As of now, we do not do dedicated automated testing as part of the release workflow but as part of each PR. Thus it will be a bit more complicated to link to a resource here that contains the test results for that release. I see two approaches and would rather fix this in a dedicated PR since it goes beyond the quevee setup.

  1. We execute the test suite during this release pipeline, add the resulting output as asset to the release, and add the URL to that asset in the quevee step
  2. We let the release action find the last PR that has been merged to main before the execution of the release action and then reference the output of that as artifacts_testing .

I am strongly in favor of option 1.
The search for the right action in option 2 seems more error-prone and the action results might be deleted at some point.

artifacts_documentation: https://docs.rs/kuksa-rust-sdk/${{ github.event.release.tag_name }}, https://crates.io/crates/kuksa-rust-sdk/${{ github.event.release.tag_name }}, README.md
artifacts_coding_guidelines: CONTRIBUTING.md
artifacts_release_process: RELEASE.md
- name: Upload quality manifest to release
uses: svenstaro/upload-release-action@v2
id: upload_manifest
with:
repo_token: ${{ secrets.GITHUB_TOKEN }}
file: ${{ steps.quevee.outputs.manifest_file }}
tag: ${{ github.ref }}
Loading