Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@
******************************************************************************/
package org.eclipse.lsp4j.jsonrpc;

public interface MessageProducer {
import java.io.Closeable;

public interface MessageProducer extends Closeable {

/**
* Listen to a message source and forward all messages to the given consumer. Typically this method
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public boolean isDone() {
public boolean cancel(boolean mayInterruptIfRunning) {
if (mayInterruptIfRunning && messageProducer instanceof Closeable) {
try {
((Closeable) messageProducer).close();
messageProducer.close();
} catch (IOException e) {
throw new RuntimeException(e);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
/**
* A message producer that reads from an input stream and parses messages from JSON.
*/
public class StreamMessageProducer implements MessageProducer, Closeable, MessageConstants {
public class StreamMessageProducer implements MessageProducer, MessageConstants {

private static final Logger LOG = Logger.getLogger(StreamMessageProducer.class.getName());

Expand Down Expand Up @@ -204,8 +204,9 @@ protected boolean handleMessage(InputStream input, Headers headers) {
}

@Override
public void close() {
public void close() throws IOException {
keepRunning = false;
input.close();
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ public int read() throws IOException {
MessageJsonHandler jsonHandler = new MessageJsonHandler(Collections.emptyMap());
try (StreamMessageProducer messageProducer = new StreamMessageProducer(input, jsonHandler)) {
messageProducer.listen(message -> {});
}
}catch (IOException e) {
throw new IllegalStateException(e);
}
}).get(TIMEOUT, TimeUnit.MILLISECONDS);
}

Expand All @@ -85,7 +87,9 @@ public int read() throws IOException {
MessageJsonHandler jsonHandler = new MessageJsonHandler(Collections.emptyMap());
try (StreamMessageProducer messageProducer = new StreamMessageProducer(input, jsonHandler)) {
messageProducer.listen(message -> {});
}
}catch (IOException e) {
throw new IllegalStateException(e);
}
}).get(TIMEOUT, TimeUnit.MILLISECONDS);
}

Expand All @@ -101,7 +105,9 @@ public int read() throws IOException {
MessageJsonHandler jsonHandler = new MessageJsonHandler(Collections.emptyMap());
try (StreamMessageProducer messageProducer = new StreamMessageProducer(input, jsonHandler)) {
messageProducer.listen(message -> {});
}
}catch (IOException e) {
throw new IllegalStateException(e);
}
}).get(TIMEOUT, TimeUnit.MILLISECONDS);
}

Expand All @@ -118,7 +124,9 @@ public int read() throws IOException {
MessageJsonHandler jsonHandler = new MessageJsonHandler(Collections.emptyMap());
try (StreamMessageProducer messageProducer = new StreamMessageProducer(input, jsonHandler)) {
messageProducer.listen(message -> {});
}
}catch (IOException e) {
throw new IllegalStateException(e);
}
}).get(TIMEOUT, TimeUnit.MILLISECONDS);
} catch (ExecutionException e) {
throw e.getCause();
Expand Down Expand Up @@ -149,11 +157,13 @@ protected void fireError(Throwable error) {
}

var jsonHandler = new MessageJsonHandler(Collections.emptyMap());
try (var producer = new TestProducer( new ByteArrayInputStream(inputStr.getBytes()), jsonHandler)) {
var received = new ArrayList<>();
producer.listen(received::add);
assertEquals("Both messages should be delivered", 2, received.size());
}
try (var producer = new TestProducer(new ByteArrayInputStream(inputStr.getBytes()), jsonHandler)) {
var received = new ArrayList<>();
producer.listen(received::add);
assertEquals("Both messages should be delivered", 2, received.size());
} catch (IOException e) {
throw new IllegalStateException(e);
}
}).get(TIMEOUT, TimeUnit.MILLISECONDS);
}

Expand Down