Handle concurrent monitored item resets - #1815
Merged
Merged
Conversation
Report Bad_InvalidState when per-item server state disappears while building monitoring mode or deletion requests. This avoids leaking race-dependent exceptions while preserving request and result alignment. Fixes #1814
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bad_InvalidStateresults when monitored item server state disappears duringSetMonitoringModeorDeleteMonitoredItemsrequest constructionRoot cause
A monitored item's
syncStateandserverStateare separate volatile fields. Session reactivation or concurrent deletion can clear them betweensetMonitoringMode()validation and the later monitored-item ID lookup, causing eitherIllegalArgumentExceptionorNoSuchElementException. The deletion path used the same throwing ID lookup pattern.Impact
Callers now receive a
Bad_InvalidStateservice result for each affected item instead of a race-dependent exception. Valid items in the same request are still sent to the server and their results remain aligned with the original input list.Validation
mise exec -- mvn -q spotless:applymise exec -- mvn -q -pl opc-ua-sdk/integration-tests -am test -Dtest=OpcUaMonitoredItemTest -Dsurefire.failIfNoSpecifiedTests=falsemise exec -- mvn -q clean compileFixes #1814