Prevent type model compiler stack overflow - #1821
Merged
Merged
Conversation
Walk declarations iteratively so the configured depth limit is enforced before JVM stack exhaustion on platforms with smaller thread stacks.
kevinherron
marked this pull request as ready for review
July 22, 2026 22:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEPTH_LIMIT_EXCEEDEDinstead of exhausting the JVM stackRoot cause
Each declaration level added both
walkChildrenandprocessChildframes. On JVMs with less usable thread stack, the native stack could be exhausted before the configured 512-level guard ran. This made the failure platform- and workload-sensitive: the focused test could pass while the full reactor failed.Validation
mise exec -- mvn -q spotless:applymise exec -- mvn -q -pl opc-ua-sdk/sdk-server -am test -Dtest=TypeModelCompilerTestmise exec -- mvn -q clean compilemise exec -- mvn -q verify