Stabilize transport network tests - #1822
Merged
kevinherron merged 1 commit intoJul 22, 2026
Merged
Conversation
Allocate coordinated loopback ports instead of sharing a fixed listener port, and make server unbind wait for accepted channels to close so test invocations cannot leak network activity into each other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
OpcTcpTransportTestreused a hard-coded listener port across its parameterized invocations. That exposed the suite to collisions with other test JVMs and unrelated local listeners. Teardown also initiated accepted child-channel closure asynchronously, so network activity could outlive the invocation that created it.Validation
mise exec -- mvn -q -pl opc-ua-stack/transport -am test -Dtest=OpcTcpTransportTest,OpcTcpServerTransportTest -Dsurefire.failIfNoSpecifiedTests=false— 96 tests passedmise exec -- mvn -q clean compile— passedmise exec -- mvn -q -pl opc-ua-stack/transport -am verify— 1,144 tests passedFull reactor note
A full
clean verifyprogressed past the transport module, then failed in the unrelatedTypeModelCompilerTest.depthBeyondLimitRejectedWithStructuredDiagnostic: the test expectedModelCompilationExceptionbut receivedStackOverflowError.