Skip to content

Clean Code for build/org.eclipse.pde.build.tests#2317

Open
eclipse-pde-bot wants to merge 1 commit intomasterfrom
clean-code/build/org.eclipse.pde.build.tests
Open

Clean Code for build/org.eclipse.pde.build.tests#2317
eclipse-pde-bot wants to merge 1 commit intomasterfrom
clean-code/build/org.eclipse.pde.build.tests

Conversation

@eclipse-pde-bot
Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@github-actions
Copy link
Copy Markdown

Test Results

   99 files   -  27     99 suites   - 27   27m 5s ⏱️ - 10m 8s
3 336 tests  - 166  3 288 ✅  - 160   48 💤  -  6  0 ❌ ±0 
8 823 runs   - 498  8 712 ✅  - 479  111 💤  - 19  0 ❌ ±0 

Results for commit 9018cf0. ± Comparison against base commit 0ca2373.

This pull request removes 166 tests.
org.eclipse.pde.build.internal.tests.AssembleTests ‑ testBug179612_custom
org.eclipse.pde.build.internal.tests.AssembleTests ‑ testBug179612_default
org.eclipse.pde.build.internal.tests.AssembleTests ‑ testBug196754
org.eclipse.pde.build.internal.tests.AssembleTests ‑ testBug211605
org.eclipse.pde.build.internal.tests.AssembleTests ‑ testBug255824
org.eclipse.pde.build.internal.tests.AssembleTests ‑ testCustomAssembly
org.eclipse.pde.build.internal.tests.FetchTests ‑ Unknown test
org.eclipse.pde.build.internal.tests.ProductTests ‑ test186224
org.eclipse.pde.build.internal.tests.ProductTests ‑ test218878
org.eclipse.pde.build.internal.tests.ProductTests ‑ test234032
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant