Fixed scrolling inside the XMI tab of the E4WorkbenchModelEditor#2321
Merged
merks merged 1 commit intoeclipse-pde:masterfrom Apr 28, 2026
Merged
Fixed scrolling inside the XMI tab of the E4WorkbenchModelEditor#2321merks merged 1 commit intoeclipse-pde:masterfrom
merks merged 1 commit intoeclipse-pde:masterfrom
Conversation
Test Results 126 files ±0 126 suites ±0 34m 0s ⏱️ - 3m 20s For more details on these failures, see this check. Results for commit 761cfeb. ± Comparison against base commit 5e3ba32. |
Contributor
|
I think the warning is this one which is an infrastructure issue not related to the PR: 
|
merks
approved these changes
Apr 28, 2026
Contributor
merks
left a comment
merks
left a comment
There was a problem hiding this comment.
Nice to use ModelEditorPreferences.TAB_FORM_SEARCH_SHOW instead of a copy of the string literal!
Contributor
|
I restarted two of the jobs to get more green verifications. |
Contributor
|
Thanks @r-mennig ❣️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2299
This PR removes the disablement of the source viewer in the XMI tab of the E4WorkbenchModelEditor. This allows scrolling inside the viewer while still keeping the contents unmodifiable.
This also enables copying of the XMI contents which might be useful e.g. for copying elementIds or other parts.
There's currently no test plugin for the XMI tab, but if #2320 gets merged, I can create a follow-up PR adding tests for the scrollbar too.