Resolve breathe input directory in bazel way#183
Open
SebSparrowHawk wants to merge 2 commits intoeclipse-score:mainfrom
Open
Resolve breathe input directory in bazel way#183SebSparrowHawk wants to merge 2 commits intoeclipse-score:mainfrom
SebSparrowHawk wants to merge 2 commits intoeclipse-score:mainfrom
Conversation
SebSparrowHawk
force-pushed
the
ssp_use_extra_opts_for_breathe
branch
3 times, most recently
from
71577c2 to
0d1461d
Compare
This allows us to specify bazel targets as breathe doxygen input instead of searching for potential projects in filesystem directly.
SebSparrowHawk
force-pushed
the
ssp_use_extra_opts_for_breathe
branch
from
0d1461d to
4fc8519
Compare
SebSparrowHawk
requested review from
LittleHuba,
castler,
hoe-jo,
limdor and
ramceb
as code owners
hoe-jo
reviewed
Apr 29, 2026
Comment on lines
+190
to
+195
| bin_marker = "/bin/" | ||
| bin_idx = matched_path.find(bin_marker) | ||
| if bin_idx >= 0: | ||
| suffix_part = matched_path[bin_idx + len(bin_marker):] | ||
| else: | ||
| suffix_part = matched_path |
Contributor
There was a problem hiding this comment.
for /bin/ there should be a bazel equivalent ctx.bin_dir.path
Contributor
Author
There was a problem hiding this comment.
Will be fixed
Comment on lines
263
to
265
| logger.info(f"[DEBUG] extra_args from parse_known_args: {extra_args}") | ||
| logger.info(f"[DEBUG] sys.argv was: {sys.argv}") | ||
| # Create processor instance |
Contributor
There was a problem hiding this comment.
Either remove or only output on a debug flag
| with redirect_stderr(stderr_processor), redirect_stdout(stdout_processor): | ||
| sphinx_args = build_sphinx_arguments(args) | ||
| sphinx_args = build_sphinx_arguments(args, extra_args) | ||
| logger.info(f"[DEBUG] Final sphinx_args: {sphinx_args}") |
Also remove some debug log messages and replace usage of static string by switching to bazel variable equivalent.
SebSparrowHawk
force-pushed
the
ssp_use_extra_opts_for_breathe
branch
from
bf9b8f6 to
066a8ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.