Add support for urban cover (param 229001)#176
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for the “urban cover” parameter (param=229001) in the mars2grib backend concept matchers so it is treated like other surface, point-in-time fields during GRIB encoding.
Changes:
- Include
229001in thepointInTimeconcept matcher so point-in-time keys are encoded using the default variant. - Include
229001in thelevtype=SFC→LevelType::Surfacemapping.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/metkit/mars2grib/backend/concepts/point-in-time/pointInTimeMatcher.h |
Adds 229001 to the default point-in-time parameter allowlist. |
src/metkit/mars2grib/backend/concepts/level/levelMatcher.h |
Maps 229001 to LevelType::Surface for SFC fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tweska
approved these changes
Mar 4, 2026
15f3c27 to
8a91357
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #176 +/- ##
===========================================
- Coverage 61.02% 60.99% -0.03%
===========================================
Files 309 309
Lines 11732 11737 +5
Branches 1035 1037 +2
===========================================
Hits 7159 7159
- Misses 4573 4578 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8a91357 to
32b51cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributor Declaration
By opening this pull request, I affirm the following: