Skip to content

Add support for urban cover (param 229001)#176

Merged
dsarmany merged 7 commits intodevelopfrom
fix/add-urban-cover
Mar 5, 2026
Merged

Add support for urban cover (param 229001)#176
dsarmany merged 7 commits intodevelopfrom
fix/add-urban-cover

Conversation

@dsarmany
Copy link
Copy Markdown
Contributor

@dsarmany dsarmany commented Mar 4, 2026

Description

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for the “urban cover” parameter (param=229001) in the mars2grib backend concept matchers so it is treated like other surface, point-in-time fields during GRIB encoding.

Changes:

  • Include 229001 in the pointInTime concept matcher so point-in-time keys are encoded using the default variant.
  • Include 229001 in the levtype=SFCLevelType::Surface mapping.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/metkit/mars2grib/backend/concepts/point-in-time/pointInTimeMatcher.h Adds 229001 to the default point-in-time parameter allowlist.
src/metkit/mars2grib/backend/concepts/level/levelMatcher.h Maps 229001 to LevelType::Surface for SFC fields.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dsarmany dsarmany force-pushed the fix/add-urban-cover branch from 15f3c27 to 8a91357 Compare March 4, 2026 12:47
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.99%. Comparing base (250f0da) to head (32b51cf).
⚠️ Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
src/metkit/mars2grib/backend/checks/matchDataset.h 0.00% 8 Missing ⚠️
...t/mars2grib/backend/deductions/backgroundProcess.h 33.33% 2 Missing ⚠️
...ars2grib/backend/checks/checkDestinELocalSection.h 0.00% 1 Missing ⚠️
...etkit/mars2grib/backend/tables/backgroundProcess.h 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #176      +/-   ##
===========================================
- Coverage    61.02%   60.99%   -0.03%     
===========================================
  Files          309      309              
  Lines        11732    11737       +5     
  Branches      1035     1037       +2     
===========================================
  Hits          7159     7159              
- Misses        4573     4578       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dsarmany dsarmany force-pushed the fix/add-urban-cover branch from 8a91357 to 32b51cf Compare March 5, 2026 08:35
@dsarmany dsarmany merged commit 32b51cf into develop Mar 5, 2026
66 checks passed
@dsarmany dsarmany deleted the fix/add-urban-cover branch March 5, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants