Feature/paramid normalisation mode

[danovaro]

Description

Contributor Declaration

By opening this pull request, I affirm the following:

• All authors agree to the Contributor License Agreement.
• The code follows the project's coding standards.
• I have performed self-review and added comments where needed.
• I have added or updated tests to verify that my changes are effective and functional.
• I have run all existing tests and confirmed they pass.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 98.40000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.93%. Comparing base (f97d405) to head (a3e9634).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/metkit/mars/ParamID.cc	66.66%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #188      +/-   ##
===========================================
- Coverage    61.95%   61.93%   -0.03%     
===========================================
  Files          303      303              
  Lines        11673    11674       +1     
  Branches      1046     1048       +2     
===========================================
- Hits          7232     7230       -2     
- Misses        4441     4444       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Adds an explicit parameter-ID normalisation mode to ParamID::normalise() and updates tests to exercise the new mode-based API instead of the previous boolean flags.

Changes:

• Introduce metkit::NormalisationMode and a new ParamID::normalise(..., NormalisationMode) overload (with deprecated legacy overloads).
• Replace the global fullTableDropping_ flag with a mode returned by ParamID::normalisationMode().
• Update tests/test_param_axis.cc to call ParamID::normalise() using NormalisationMode (including Strict, Loose, FullTableDropping cases).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
tests/test_param_axis.cc	Migrates param-axis tests from (useParamId, fullTableDropping) booleans to NormalisationMode inputs.
src/metkit/mars/ParamID.h	Adds NormalisationMode, introduces the mode-based normalise overload, and deprecates legacy APIs.
src/metkit/mars/ParamID.cc	Loads/stores the configured default normalisation mode from param-matching.yaml.

Impacted files under src/metkit/mars2grib/**: none (documentation sync checks not applicable).

[Copilot]

The inline comments on NormalisationMode are misleading: Strict currently disables the partial-match logic (it is guarded by !strict), so Loose is not “Strict + partial match”. Please adjust these comments to reflect the actual behaviors (e.g., whether GRIB1 value matching and table-expansion are enabled) to avoid confusing API users.

Suggested change

	Strict, // Exact match + wind conversion
	Loose, // Strict + partial match (dropping tables defined in param-matching.yaml)
	FullTableDropping
	Strict, // Exact match only (no partial table expansion) + wind conversion
	Loose, // GRIB1-style/value-based matching with partial table expansion from param-matching.yaml +
	// wind conversion
	FullTableDropping // GRIB1-style/value-based matching with full configured table dropping + wind conversion

[Copilot]

This debug output prints a constant false for Wind, which is confusing when diagnosing test failures. Consider printing windRequested (and/or expectWind) here so the log reflects the actual state being asserted later.

Suggested change

	std::cout << "Wind:" << false << std::endl;
	std::cout << "Initial Wind:" << windRequested << ", Expected Wind:" << expectWind << std::endl;