week1 day1 exercise - #1586
Open
kavyahj04 wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The notebook as added won’t run cleanly in a fresh kernel (missing client/init) and includes malformed prompt strings that will produce incorrect instructions/output.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a new Day 1 exercise notebook under 1_foundations/community_contributions/ to demonstrate multi-step prompting (business area → pain point → agentic solution) using sequential LLM calls.
Changes:
- Introduces a new
day1.ipynbnotebook with an exercise prompt and two code cells that chain multipleopenai.chat.completions.create(...)calls. - Formats the final result for notebook display via
Markdown.
File summaries
| File | Description |
|---|---|
| 1_foundations/community_contributions/kavyahj04/week01/day1.ipynb | New notebook implementing a chained LLM exercise (idea → pain point → solution). |
Review details
Suppressed comments (2)
1_foundations/community_contributions/kavyahj04/week01/day1.ipynb:60
- This prompt is missing punctuation between
{business_area}and the instruction, which makes the user message harder to read and can reduce output quality.
"messages = [{\"role\": \"user\", \"content\": f\"Here is the business area: {business_area} present a pain point in this industry.\"}]\n",
1_foundations/community_contributions/kavyahj04/week01/day1.ipynb:67
- The final prompt concatenates
industry{pain_point}without a separator and also misses a space insolution.While, producing a malformed instruction string. Include the retrievedpain_pointwith clear separators and spacing.
"messages = [{\"role\": \"user\", \"content\": f\"Here is the business area: {business_area} present a pain point in this industry{pain_point}, propose the Agentic AI solution.While proposing follow this structure. 1. Business Area 2. Pain Point 3. Agentic AI solution\"}]\n",
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+34
to
+40
| "# First create the messages:\n", | ||
| "message = \"You are a helpful assistant who pick a business area that might be worth exploring for an Agentic AI opportunity.\"\n", | ||
| "messages = [{\"role\": \"user\", \"content\": \"Something here\"}]\n", | ||
| "\n", | ||
| "# Then make the first call:\n", | ||
| "\n", | ||
| "response = openai.chat.completions.create(model=\"gpt-5.4-mini\", messages=messages)\n", |
Comment on lines
+15
to
+16
| " Finally have 3 third LLM call propose the Agentic AI solution. <br/>\n", | ||
| " We will cover this at up-coming labs, so don't worry if you're unsure.. just give it a try!\n", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.