Skip to content

dotMorten lib is not needed, and this is not a bug fix. - #117

Closed
mehdihaghshenas wants to merge 24 commits into
efcore:mainfrom
mehdihaghshenas:main
Closed

dotMorten lib is not needed, and this is not a bug fix.#117
mehdihaghshenas wants to merge 24 commits into
efcore:mainfrom
mehdihaghshenas:main

Conversation

@mehdihaghshenas

@mehdihaghshenas mehdihaghshenas commented Nov 13, 2022

Copy link
Copy Markdown

No description provided.

@ErikEJ

ErikEJ commented Nov 13, 2022

Copy link
Copy Markdown
Member

This library should use the official Microsoft.SqlServer.Types package.

@ErikEJ

ErikEJ commented Nov 13, 2022

Copy link
Copy Markdown
Member

Also EF Core 7 targets .NET 6

@mehdihaghshenas

Copy link
Copy Markdown
Author

This library should use the official Microsoft.SqlServer.Types package.

but https://www.nuget.org/packages/Microsoft.SqlServer.Types/ only support dot net 4.x

@ErikEJ

ErikEJ commented Nov 13, 2022

Copy link
Copy Markdown
Member

No, the latest version supports .NET Standard 2.1 https://www.nuget.org/packages/Microsoft.SqlServer.Types/160.900.6-rc0#supportedframeworks-body-tab

@mehdihaghshenas

Copy link
Copy Markdown
Author

No, the latest version supports .NET Standard 2.1 https://www.nuget.org/packages/Microsoft.SqlServer.Types/160.900.6-rc0#supportedframeworks-body-tab

Thank you so much

@mehdihaghshenas

Copy link
Copy Markdown
Author

@bricelam
can you publish a new version of this package
we have problem to use rc version with EF 7.0.0

Comment thread .github/workflows/dotnet.yml Outdated
Comment thread EFCore.SqlServer.HierarchyId.Test/EFCore.SqlServer.HierarchyId.Test.csproj Outdated
Comment thread EFCore.SqlServer.HierarchyId.Test/EFCore.SqlServer.HierarchyId.Test.csproj Outdated
Comment thread EFCore.SqlServer.HierarchyId.Test/RelationalScaffoldingModelFactoryTest.cs Outdated
@ErikEJ

ErikEJ commented Nov 15, 2022

Copy link
Copy Markdown
Member

Suggest you update the title and initial comment on this PR - dotMorten lib is not needed, and this is not a bug fix.

@mehdihaghshenas mehdihaghshenas changed the title Fix bugs after upgrade to EF 7.0 dotMorten lib is not needed, and this is not a bug fix. Nov 15, 2022
Comment thread EFCore.InMemory.HierarchyId/EFCore.InMemory.HierarchyId.csproj Outdated
@bricelam

Copy link
Copy Markdown
Member

New versions have been uploaded to NuGet.org. See #113 for switching to the official SqlServer.Types package

@bricelam bricelam closed this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants