invalidate cache when the expected binary is missing#268
Merged
Conversation
A populated cache dir was treated as a hit on install_dir.exists() alone, without checking the executor's binary was actually there. When a tool's backing executor changes between gg versions (e.g. codex moving from a GitHub release to the @openai/codex npm package), the old dir lingered and prep returned a hit that then failed at run time with "Unable to find executable", until the user manually cleared the cache. prep now verifies the expected bin resolves under the cache's own search paths (not $PATH) before accepting a hit; if it doesn't, the stale dir is removed and a fresh download runs. The resolution logic is factored out of try_run into a shared resolve_bin_path so the cache check and the run path stay in lock-step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A populated cache dir was treated as a hit on install_dir.exists() alone, without checking the executor's binary was actually there. When a tool's backing executor changes between gg versions (e.g. codex moving from a GitHub release to the @openai/codex npm package), the old dir lingered and prep returned a hit that then failed at run time with "Unable to find executable", until the user manually cleared the cache.
prep now verifies the expected bin resolves under the cache's own search paths (not $PATH) before accepting a hit; if it doesn't, the stale dir is removed and a fresh download runs. The resolution logic is factored out of try_run into a shared resolve_bin_path so the cache check and the run path stay in lock-step.