This repository was archived by the owner on Apr 8, 2026. It is now read-only.
Original Music Player#39
Open
zacharynoel wants to merge 226 commits into
Open
Conversation
…ify player. Not working currently because of null pointer exception on line 87 in SongActivity.
…ate and can only view contents if correct code is entered.
Signed-off-by: Eitan Simler <eitan.simler@gmail.com>
# Conflicts: # app/src/main/java/com/houseparty/houseparty/LoginActivity.java
Removed to prevent errors when pulling from different computers
…l cause chosen song to be immediatly played. Spotify is still broken from previous changes.
# Conflicts: # app/app.iml # app/src/main/java/com/houseparty/houseparty/NewSongActivity.java
… code in loginActivity and PlaylistActivity so that registration, login, and playlist creation could be tested programmatically.
Collaborator
|
As the original model for the music player for House Party, this design is reasonably effective for modeling a list of songs. My only criticism would be that the list view is not the most effective object to store songs, and would be more useful if replaced with the a custom adapter object. A custom adaptor object would be better equipped to respond to user input and dynamically update the constantly changing playlist. Also, the hard coded songs are very useful in helping to test the player. |
# Conflicts: # app/build.gradle
# Conflicts: # app/src/main/java/com/houseparty/houseparty/LoginActivity.java # app/src/main/java/com/houseparty/houseparty/PlaylistActivity.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Music player prior to pause/play button redesign