Skip to content
This repository was archived by the owner on Apr 8, 2026. It is now read-only.

Pull request for code review#41

Open
TeoDoughty wants to merge 147 commits into
Facadefrom
master
Open

Pull request for code review#41
TeoDoughty wants to merge 147 commits into
Facadefrom
master

Conversation

@TeoDoughty

@TeoDoughty TeoDoughty commented Jun 8, 2018

Copy link
Copy Markdown
Collaborator

No description provided.

TeoDoughty and others added 30 commits April 28, 2018 19:04
@TeoDoughty
Added register button
05c3a3d
@jkurtz678
Added Firebase login and registration to LoginActivity
1f4b87a
@jkurtz678
Merge remote-tracking branch 'origin/master' into FrontEnd
ec57ca8 
# Conflicts:
#	.idea/misc.xml
#	app/app.iml
#	app/build.gradle
#	app/src/main/java/com/houseparty/houseparty/LoginActivity.java
@TeoDoughty
Added alternative songActivity
c2e15eb 
added pause/play
added space for art
@jkurtz678
Merge remote-tracking branch 'origin/FrontEnd' into FrontEnd
7d3dcdc
@jkurtz678
Fixed passcodes for playlists
319c918
@jkurtz678
Updates to SongActivity and Factory, still broken.
cfc1e16
@jkurtz678
Implemented new front end screen for song activity
789977f
@eitan12345om
Added Travis CI
c53ef6c
@jkurtz678
added new song class
33b197b
@eitan12345om
Adding some stuff. Merge
4d0b2a7
@eitan12345om
Updated
d3ec3d2
@eitan12345om
Updated
524b9be
@eitan12345om
Updated
3d23061
@eitan12345om
Trying again
1d99b7e
@eitan12345om
Updated again, bitches
cbcc311
@eitan12345om
Updated again, beeotches
62f033f
@eitan12345om
Updated again
f7d5966
@eitan12345om
Updaed the Readme
d1ffd86
@jkurtz678
added new activity xml
dfe477e
@jkurtz678
Merge branch 'Sprint3' of https://github.com/eitan12345om/HouseParty …
285ab86 
…into Sprint3
@eitan12345om
Updated
0b44c99
@eitan12345om
Updated
9d7252e
@eitan12345om
Fixed the issue with the build.gradle
4d48f83
@eitan12345om
Fixed the issue with the invalid button
bbfc5fb
@eitan12345om
Fixed the issue with the invalid button
b0d2f10
@eitan12345om
Finally frickin got the build.gradle right for Cucumber
e252eef
@eitan12345om
Commented out old unit test methods
4652de1
@eitan12345om
Changed SongActivityUnitTest methods
8c26659
@eitan12345om
Reformatted
0881f78
eitan12345om and others added 21 commits June 3, 2018 17:43
@eitan12345om
Thumbs now get pushed!
8a7c9f4
@jkurtz678
napster register and create player
49754bd
@eitan12345om
Song playing doesn't work. Please get it to be out of SpotifySong
1bb19a6
@hanskamin
Refer to queues as "Parties" to fit the theme.
b6db2e5
reverted spotifyPlayer object to static usage
582571d
@jkurtz678
Added basic napster support. Selecting napster in add song screen wil…
2570860 
…l cause chosen song to be immediatly played. Spotify is still broken from previous changes.
@jkurtz678
Merge branch 'NapsterBranch'
f9101fd 
# Conflicts:
#	app/app.iml
#	app/src/main/java/com/houseparty/houseparty/NewSongActivity.java
@jkurtz678
Merged napster branch to master
febe3d9
@eitan12345om
Some GUI tests
76c3b5d
@jkurtz678
Fixed napster basic usage. Added acceptance test features.
d987489
@jkurtz678
First two acceptance tests implemented. These required refactoring of…
fd37b8f 
… code in loginActivity and PlaylistActivity so that registration, login, and playlist creation could be tested programmatically.
@eitan12345om
Removed Code Smells
d825bb5
@eitan12345om
Merge remote-tracking branch 'origin/master'
891b13f 
# Conflicts:
#	app/build.gradle
@eitan12345om
Removed Code Smells
84bf02d
@eitan12345om
Removed Code Smells
2d45905
@eitan12345om
Removed Code Smells
90dbfe3
@eitan12345om
Removed Code Smells
147b88a
@eitan12345om
Removed all the Code Smells
1074262
@eitan12345om
Removed all the Code Smells
66a887b
@eitan12345om
Not aborting on error
b2d789c
@eitan12345om
Fixed
1aec647
@eitan12345om

eitan12345om commented Jun 9, 2018

Copy link
Copy Markdown
Owner

Matt,

You made some awesome contributions to this project. I really appreciate your work on the LoginActivity Page; this was an integral part of our application. We could not have integrated a login system without your valuable contributions.
I would like to suggest that you make smaller commits so that each change can be reviewed individually. Right now, the commit I reviewed is large and contains many lines of code doing different things. Having a smaller commit would make it easier for me to determine what you are trying to do with each commit.
Additionally, it would be helpful if you had separate commits for different files if they are doing different things and/or are part of different additions to features.
I would also like to suggest that you document your contributions with comments conforming to our coding style. This will make it easier for you and other developers to pick up from where you left off.
I think your functions are short and sweet and have a modular mouthfeel.
Finally, your overall contributions were timely and important.

Keep up the good work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TeoDoughty @eitan12345om @jkurtz678 @hanskamin @zacharynoel