Fix formating & add needed config for xpack.security.remote_cluster_s…#6732
Fix formating & add needed config for xpack.security.remote_cluster_s…#6732SimonKoetting wants to merge 7 commits into
Conversation
…erver.ssl setting when using own certificates
Elastic Docs AI PR menuCheck the box to run an AI review for this pull request.
Powered by GitHub Agentic Workflows and docs-actions. For more information, reach out to the docs team. |
🔍 Preview links for changed docs |
Elastic Docs Style Checker (Vale)Summary: 1 suggestion found 💡 Suggestions (1): Optional style improvements. Apply when helpful.
The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
|
Great catch @SimonKoetting , thanks for sharing this. Now that the footnote Would you mind if I apply a commit to your PR and we can review it together before merging? Or do you prefer if we merge this change and then I create a follow-up PR to update the format of the content a bit? I'd like to make sure that the reader understands that the |
|
@eedugon sound good to me, feel free to add the commit to this PR so we can address this right away :) |
…ty transport certs. This updates the transport certificate guidance to show the required DNS and SSL settings for API key-based remote cluster server usage, with a complete example and cross-links between related ECK docs. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@SimonKoetting , I have commited directly to your branch with a format change, and also included the opposite link: If a user is configuring remote cluster server interface and they are already using certificates created by a third-party tool they should also follow this guidance. For the example I'm not sure if the current @shainaraskas , would you please share your thoughts here? it's a very small PR that covers a small gap that we had in our docs between RCS 2.0 (api key based auth) and ECK not handling transport certs automatically. The options for the content in
|
SimonKoetting
left a comment
There was a problem hiding this comment.
Besides this little nit, the changes look good to me. 👍 @eedugon
|
@SimonKoetting : I've applied your suggestion and also converted the Let us know your thoughts, and thanks a lot for your patience :) |
|
LGTM :) @eedugon |
yetanothertw
left a comment
There was a problem hiding this comment.
Nice work! Really like that you've moved the dropdown into its own section for maximum clarity. 🪴
I've left a minor (not a blocker) comment re the elasticsearch version in your example config manifest, see what you think.
| metadata: | ||
| name: quickstart | ||
| spec: | ||
| version: 8.16.1 |
There was a problem hiding this comment.
This might not even be relevant, but should we try to use 9.something as this is the 9.X docset?
There was a problem hiding this comment.
yeah, I'm planning to address all ECK examples in a different PR, to use {{version.stack}} where applicable.
For the moment I've left the example as a copy&paste of the previous example but with the extra needed settings.
|
@eedugon sorry I missed this. I like the new section. it's a good alternative to the big footnote |
Summary
Fix formating & add needed configs for xpack.security.remote_cluster_server.ssl setting when using own certificates
Generative AI disclosure