fix error reporting when plugin uses unsupported concurrency#19040
Open
yaauie wants to merge 1 commit into
Open
fix error reporting when plugin uses unsupported concurrency#19040yaauie wants to merge 1 commit into
concurrency#19040yaauie wants to merge 1 commit into
Conversation
Contributor
🤖 GitHub commentsJust comment with:
|
yaauie
commented
Apr 22, 2026
| String.format( | ||
| "Could not find output delegator strategy of type '%s'. Value strategies: %s", | ||
| type.asJavaString(), | ||
| map.values(context).stream().map(v -> ((IRubyObject) v).asJavaString()) |
Member
Author
There was a problem hiding this comment.
IRubyObject#asJavaString has a base implementation in RubyBasicObject that throws a type-error unless the IRubyObject is string-like (e.g., trivially coercible to a string), so it doesn't work well with the RubyClass instances that are values in the map.
Contributor
|
This pull request does not have a backport label. Could you fix it @yaauie? 🙏
|
💚 Build Succeeded
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
What does this PR do?
Improves the error message when a pipeline includes a plugin with an unsupported concurrency type. These types are declared in the plugin itself, not in the pipeline configuration.
Why is it important/What is the impact to the user?
It helps us chase down the real issue, instead of a separate issue that occurs while describing the available concurrency types.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature worksHow to test this PR locally
/vendor/bundle/jruby/*/gems/logstash-output-*/ to haveconcurrency :bananas` instead of one of the supported concurrency typesWithout this patch, the error message looks like:
Related issues
Use cases
Screenshots
Logs