Improve version bump flexibility and automate AWS and sequel deps to minor updates#19113
Closed
alexcams wants to merge 3 commits into
Closed
Improve version bump flexibility and automate AWS and sequel deps to minor updates#19113alexcams wants to merge 3 commits into
alexcams wants to merge 3 commits into
Conversation
…onfig parameter to improve flexibility
Contributor
🤖 GitHub commentsJust comment with:
|
cb60b0a to
262037d
Compare
262037d to
86b47ff
Compare
bbf2320 to
02fde75
Compare
donoghuc
reviewed
May 20, 2026
Member
donoghuc
left a comment
There was a problem hiding this comment.
As we discussed in person, lets extend this pattern (identify gems for which we explicitly want to include minor versions for by default in a whitelist) to 9.x. Looks like we might be best off with targetting at main then backporting to all active branches (and updating defaults as needed in the backport PRs).
I'm cool with starting off with dynamically generating the whitelist (for example ./vendor/jruby/bin/jruby -S bundle list --name-only | grep '^aws-') we should keep an eye on this and make sure it is complete over the course of a few runs (IE no false positive/negative). We can always manage a static list down the road if we find it to be too complex to dynamically generate it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Automate AWS and sequel minor bump on lock file patch bumps and adds a config parameter to version bump workflow to improve its flexibility.
Why is it important/What is the impact to the user?
It allows to select gems where a desired feature/fix has been shipped as minor release and also keeps up to date gemps that don't ship patch releases.
Related issues
Tests
Example job run and PR created with
multi_jsonas minor selected gem andpublic_suffixas major. AWS and sequel also downgraded manually to see them automatically updated to last minor.