Skip to content

Improve version bump flexibility and automate AWS and sequel deps to minor updates#19113

Closed
alexcams wants to merge 3 commits into
elastic:8.19from
alexcams:7160-logstash-improve-version-bump-flexibility_8_19
Closed

Improve version bump flexibility and automate AWS and sequel deps to minor updates#19113
alexcams wants to merge 3 commits into
elastic:8.19from
alexcams:7160-logstash-improve-version-bump-flexibility_8_19

Conversation

@alexcams
Copy link
Copy Markdown
Contributor

@alexcams alexcams commented May 14, 2026

  • enhancement

Release notes

[rn:skip]

What does this PR do?

Automate AWS and sequel minor bump on lock file patch bumps and adds a config parameter to version bump workflow to improve its flexibility.

Why is it important/What is the impact to the user?

It allows to select gems where a desired feature/fix has been shipped as minor release and also keeps up to date gemps that don't ship patch releases.

Related issues

Tests

Example job run and PR created with multi_json as minor selected gem and public_suffix as major. AWS and sequel also downgraded manually to see them automatically updated to last minor.

@alexcams alexcams marked this pull request as draft May 14, 2026 15:52
@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
  • run exhaustive tests : Run the exhaustive tests Buildkite pipeline.

@alexcams alexcams force-pushed the 7160-logstash-improve-version-bump-flexibility_8_19 branch from cb60b0a to 262037d Compare May 15, 2026 07:25
@alexcams alexcams force-pushed the 7160-logstash-improve-version-bump-flexibility_8_19 branch from 262037d to 86b47ff Compare May 15, 2026 07:26
@alexcams alexcams marked this pull request as ready for review May 15, 2026 08:03
@alexcams alexcams changed the title Improve version bump flexibility. Improve version bump flexibility and automate AWS and sequel deps to minor automatically May 15, 2026
@alexcams alexcams force-pushed the 7160-logstash-improve-version-bump-flexibility_8_19 branch from bbf2320 to 02fde75 Compare May 18, 2026 10:45
@alexcams alexcams changed the title Improve version bump flexibility and automate AWS and sequel deps to minor automatically Improve version bump flexibility and automate AWS and sequel deps to minor updates May 20, 2026
Copy link
Copy Markdown
Member

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed in person, lets extend this pattern (identify gems for which we explicitly want to include minor versions for by default in a whitelist) to 9.x. Looks like we might be best off with targetting at main then backporting to all active branches (and updating defaults as needed in the backport PRs).

I'm cool with starting off with dynamically generating the whitelist (for example ./vendor/jruby/bin/jruby -S bundle list --name-only | grep '^aws-') we should keep an eye on this and make sure it is complete over the course of a few runs (IE no false positive/negative). We can always manage a static list down the road if we find it to be too complex to dynamically generate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants