Fix empty custom separator decompile#195
Open
CorrectRoadH wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@electrikmilk I split this out from #192 into this separate PR as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes decompiling text actions that use a custom separator set to an empty string.
Previously, decompTextParts only emitted the separator argument when the decompiled separator value was non-empty. That meant an explicit empty custom separator was dropped from the generated Cherri code, changing the behavior of the imported Shortcut.
This keeps track of whether WFTextCustomSeparator was present separately from its value, so an empty string can still be emitted as an intentional argument.
A regression test was added for the empty custom separator case. I verified this with go test -run TestDecompileTextPartsKeepsEmptyCustomSeparator and go test -run TestDecomp.