Introduce side-widget in Abstract Slot and use for preview window by jeremypw · Pull Request #2714 · elementary/files

jeremypw · 2026-01-29T19:42:53Z

Instead of inserting preview widget into slot stack in Miller it is added as a side-widget to the main AbstractSlot (will also work for other views). This minimises impact on the Miller view and makes it easier to fix some issues.

The side-widget is added into a Paned so the space it takes up can be adjusted by the user.

The preview size has been reduced to be more comparable to the directory slots but wide enough not to cause undue wrapping of the property information

The preview size was chosen to minimise the appearance of black bars to the sides (sometimes) when the window height is changed. I think this may be a window manager issue?

The Miller View now keeps the active slot in view when the space available to it changes either due to window resizing or preview widget space changing.

It would be nice if the width of the active slot were kept above a minimum but that applies to main anyway so can be done in a separate PR.

jeremypw · 2026-01-29T19:48:07Z

@danirabbit There's probably some clean-up and refinement to do but I would appreciate some feedback before going any further.

danirabbit · 2026-01-30T18:45:18Z

Yeah this seems like a much better direction. Nice job!

I've got some weird gap here added to the end of the scrollable area:

jeremypw · 2026-01-31T16:41:29Z

@danirabbit Thanks for the review! I am encouraged to spend more time on it. That gap has always been there in Miller View as a consequence of the need to have space for the column to expand into (see calculate_total_width function), but before it lay outside the window. I'll see what I can do to hide it.

jeremypw · 2026-01-31T18:43:06Z

@danirabbit I have got rid of the gap now but you can reveal the expand-into space by reducing the preview width with the paned (or window larger or deselecting) if you do need to make the last slot larger. Whenever a "scroll to slot" is performed the gap disappears.

I have also made other minor refinements to scroll handling.

I'll dog-food it for a while but if you see anything let me know.

# Conflicts resolved: # libcore/AbstractSlot.vala # plugins/pantheon-files-trash/plugin.vala # src/View/Miller.vala

jeremypw · 2026-02-20T15:41:29Z

@danirabbit Further releases of Files are pretty much blocked until the preview facility is acceptable. I would be grateful for your input on this PR which, I think, fixes a number of issues with the current situation.

danirabbit · 2026-03-05T20:53:36Z

I feel like we've gone better in a lot of ways and worse in some ways. Can you revert any changes you've made to the design of the contents of the pane? So changes to scrolled areas, adding the separator etc. I'd like to consider those kinds of changes separately

This reverts commit f16a4aa.

This reverts commit cb0eb4c. # Conflicts: # src/View/DetailsColumn.vala

This reverts commit b965c98.

This reverts commit 388426f.

This reverts commit c0e20b6. # Conflicts: # src/View/DetailsColumn.vala

jeremypw · 2026-03-07T19:07:25Z

@danirabbit Not sure exactly what you want but I have reverted all changes made to the DetailsColumn widget since moving to side widget.

jeremypw · 2026-04-18T17:24:49Z

@danirabbit Any chance of having another look at this? It is needed for the next release.

danirabbit

Thanks for the ping :) Just a few code comments otherwise this looks good. Sorry for taking a while to review!

danirabbit · 2026-04-21T15:56:27Z

+    protected Gtk.Grid content_box;
+    protected Gtk.Paned side_widget_box;


Can we make sure to name this in a way that indicates what they are. These names imply that they're Gtk.Box. It should instead be content_grid and side_widget_paned I think

Better names now used

danirabbit · 2026-04-21T16:00:22Z

+        if (!pad) {
+            return s;
+        }


I don't see where this is ever set false?

Hmm, I clearly intended an option not to pad the datetime but I cannot remember what situation I was thinking of. Anyway it is not used in this PR (now) so I'll remove.

Ahh, I remember now - we need to not pad the datetime in the DetailsColumn. I will how actually implement that!

danirabbit · 2026-04-21T16:01:37Z

            guest.slot_number = (host != null) ? host.slot_number + 1 : 0;
            guest.colpane = new Gtk.Box (Gtk.Orientation.HORIZONTAL, 0);
-            guest.colpane.set_size_request (guest.width, -1);
+            // guest.colpane.set_size_request (guest.width, -1);


Some commented code here

danirabbit · 2026-04-21T16:02:07Z

+            guest.colpane.set_size_request (
+                2 * guest.width, -1
+            );


Can we use just width_request since the height request is -1?

danirabbit · 2026-04-21T16:03:12Z

                total_width += slot.width;
            });
+
+            this.colpane.set_size_request (total_width, -1);


Another place where we can probably use width_request instead of set_size_request

jeremypw added 19 commits January 6, 2026 16:10

Include details width in slot width, scroll to slot on show, hide

558ceda

Merge branch 'main' into jeremypw/details-column/scroll

42d5663

Merge branch 'main' into jeremypw/details-column/scroll

6857257

Ensure details drawn in last slot

9c4e9a2

Allow side widget in AbstractSlot (using Box)

8d7d9d4

Use only one scrolled window in DetailsColumn

c0e20b6

Add details column as Miller slot side widget

c59ed92

Tweak packing of details column

afc343a

Use Paned to contain content_box and detailscolumn

f5229e7

Tweak packing into paned

586018a

Scroll to current slot when paned pos changes

470ce88

Make preview width comparable to columnview

388426f

Lose unneeded spinner

b965c98

FileUtils: option not to pad formatted date-time

b08daf5

Allow value labels to wrap and ellupsize

d9f4001

Packing of side widget specified by caller

b370eff

DetailsColumn: Use unpadded date-time, simplify

cb0eb4c

DetailsColumn: Simplify layout

f16a4aa

Miller: specify packing of details column into paned

8f18a31

jeremypw requested a review from danirabbit January 29, 2026 19:43

Cleanup lint

8572bef

jeremypw mentioned this pull request Jan 29, 2026

Column preview gets cut off #2696

Closed

3 tasks

jeremypw added 2 commits January 30, 2026 17:17

AbstractSlot: Layout overlay on construct to ensure correct position

64f73ae

Ensure trash plugin updates when active slot changes without reloading

cc94e5a

Refine scrolling and sizing in Miller View

36ea315

jeremypw mentioned this pull request Feb 2, 2026

Fix horizontal scrolling to show details column #2703

Closed

Merge branch 'main' into jeremypw/details-column/reposition

2a79d9d

# Conflicts resolved: # libcore/AbstractSlot.vala # plugins/pantheon-files-trash/plugin.vala # src/View/Miller.vala

danirabbit and others added 2 commits February 20, 2026 08:11

Merge branch 'main' into jeremypw/details-column/reposition

3fe484b

Merge branch 'main' into jeremypw/details-column/reposition

c4cbd81

jeremypw requested a review from a team March 2, 2026 15:31

Merge branch 'main' into jeremypw/details-column/reposition

305b948

jeremypw added 6 commits March 7, 2026 18:36

Revert "DetailsColumn: Simplify layout"

ca95aa4

This reverts commit f16a4aa.

Revert "DetailsColumn: Use unpadded date-time, simplify"

26c8502

This reverts commit cb0eb4c. # Conflicts: # src/View/DetailsColumn.vala

Revert "Lose unneeded spinner"

ea611f6

This reverts commit b965c98.

Revert "Make preview width comparable to columnview"

d06c5d2

This reverts commit 388426f.

Revert afc343a relating to DetailsColumn

d34aea3

Revert "Use only one scrolled window in DetailsColumn"

7a7d152

This reverts commit c0e20b6. # Conflicts: # src/View/DetailsColumn.vala

jeremypw added this to the 7.3.0 milestone Mar 19, 2026

jeremypw mentioned this pull request Apr 18, 2026

Release version 7.3.0 #2688

Merged

2 tasks

Merge branch 'main' into jeremypw/details-column/reposition

81bed30

danirabbit requested changes Apr 21, 2026

View reviewed changes

jeremypw added 5 commits April 23, 2026 17:23

Use more meaningful names for two slot members

166be56

Do not pad datetime in details column

7df7101

Remove commented out code

450fc5e

Use width_request property where possible

9748554

Merge branch 'main' into jeremypw/details-column/reposition

cd91b20

jeremypw requested a review from danirabbit April 23, 2026 16:56

danirabbit approved these changes Apr 23, 2026

View reviewed changes

danirabbit merged commit 88b38d7 into main Apr 23, 2026
4 checks passed

danirabbit deleted the jeremypw/details-column/reposition branch April 23, 2026 18:56

		protected Gtk.Grid content_box;
		protected Gtk.Paned side_widget_box;

Uh oh!

Conversation

jeremypw commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jeremypw commented Jan 29, 2026

Uh oh!

danirabbit commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jeremypw commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jeremypw commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jeremypw commented Feb 20, 2026

Uh oh!

danirabbit commented Mar 5, 2026

Uh oh!

jeremypw commented Mar 7, 2026

Uh oh!

jeremypw commented Apr 18, 2026

Uh oh!

danirabbit left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jeremypw commented Jan 29, 2026 •

edited

Loading

danirabbit commented Jan 30, 2026 •

edited

Loading

jeremypw commented Jan 31, 2026 •

edited

Loading

jeremypw commented Jan 31, 2026 •

edited

Loading