optimize poseidon2 - #10
Merged
lighter-zz merged 10 commits intoDec 9, 2025
Merged
Conversation
Closed
lighterabc
reviewed
Dec 8, 2025
lighterabc
reviewed
Dec 9, 2025
lighterabc
approved these changes
Dec 9, 2025
lighterabc
added a commit
to elliottech/poseidon_crypto
that referenced
this pull request
Dec 11, 2025
elliottech/plonky2#10 It is %20-25 faster
lighter-zz
added a commit
that referenced
this pull request
Dec 11, 2025
* everything works now except for cyclic recursion * wip * update benchmarks * add more tests * fix recursion tests * fix bug in benchmarking * wip * accelerating with neon * clean up * update poseidon2's benchmark * clean up * clean up benchmark * testing recursion for both poseidon and poseidon2 * clippy * fix tests * make the tests more thorough * try to fix CI * more CI fix * clippy * roll back to lighter's version of poseidon for easy review * Update gate.rs * address comments * more debug assert * fix typo * remove stable feature * optimize poseidon2 (#10) * optimize poseidon2 * Merge branch 'zz/impl_poseidon2_with_plonky3' into zz/optimize_poseidon2 * finally faster than poseidon * clean up * update num_constants for poseidon * reverting add_canonical_u64 * Update hash.rs * Update hash.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second PR. Split for the ease of reviewing. See #9 for more details.