fix: restore the /v1 prefix on the stream URL, dot glyph for a flat tool fold - #130
Merged
Merged
Conversation
…with a dot The backend never dropped the /v1 prefix, so the WebSocket URL the CLI builds by hand (the one route not owned by the SDK) has been 404ing since #103. Put the prefix back and correct every apiRoutes help line, which advertised the prefix-free paths. Also: a tool run that opens a turn branches off nothing, so its collapsed fold (Ran 1 tool call) takes the assistant's dot instead of the branch glyph. The branch is reserved for a run that hangs off a message.
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 47bb670 in 4 minutes, 20 seconds.
- Reviewed
1commit with412lines of code in24files - Ran
1review agent producing0comments where0were posted - This pipeline runs no gatekeeper, so findings are posted as written.
- View full details on ellipsis.dev
This review was created by . You can tag
@ellipsis in this pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/v1prefix on the belief the backend had, butv1_router.pystill mounts atprefix="/v1"(/v1/meanswers 401,/meanswers 404). Restored.apiRouteshelp line and the two prose route mentions, which advertised prefix-free paths. Verified each against the router's real paths.⎿.Test plan
bun run typecheckbunx vitest run(427 passing)agent session start --watchagainst prod: the stream connects instead of 404ingImportant
Restores the
/v1prefix on the WebSocket stream URL and corrects all CLI route documentation to match the backend's actual paths.buildStreamUrl()now includes/v1(/v1/sessions/{id}/streaminstead of/sessions/{id}/stream), fixing the 404 that occurred when streaming sessions.apiRoutes()documentation strings across 18 command files updated to show/v1/prefix — these were advertising prefix-free paths but the backend router mounts atprefix="/v1", making them incorrect.●instead of⎿, since they branch off nothing (only nested folds get the branch glyph).This description was created by
for 47bb670. It will automatically update as commits are pushed.