fix: shorten cancellation notification label to prevent wrapping on mobile#1034
Open
harshitbshah wants to merge 1 commit intoellite:mainfrom
Open
fix: shorten cancellation notification label to prevent wrapping on mobile#1034harshitbshah wants to merge 1 commit intoellite:mainfrom
harshitbshah wants to merge 1 commit intoellite:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the subscription edit form, the Notify me dropdown and the Cancellation Notification date picker are laid out side by side in a 66/33 split (desktop) or 50/50 split (mobile). On mobile, the label "Cancellation Notification" is too long to fit on a single line at 50% column width, causing it to wrap to two lines. This pushes the date input down, misaligning it with the "Notify me" dropdown next to it — making the form look broken and harder to use.
Before:
After:
Fix
Shortened the English label for the
cancellation_notificationkey from "Cancellation Notification" to "Cancel reminder" inincludes/i18n/en.php.Why not a CSS fix?
An alternative approach would be to stack the two fields vertically on mobile (
flex-wrap: wrap). However, this is a more invasive layout change and unnecessary — the label text is the root cause. A shorter label is simpler, less risky, and keeps the compact side-by-side layout that works well when labels fit on one line.