This repository was archived by the owner on Aug 23, 2018. It is now read-only.
Add feature: "add css links" #138#235
Open
epsilonhalbe wants to merge 1 commit intoelm-lang:masterfrom
epsilonhalbe:master
Open
Add feature: "add css links" #138#235epsilonhalbe wants to merge 1 commit intoelm-lang:masterfrom epsilonhalbe:master
epsilonhalbe wants to merge 1 commit intoelm-lang:masterfrom
epsilonhalbe:master
Conversation
- add a new flag -c/--cssincludes such that multiple css files can be added to your standard html via `elm-reactor -c "http://localhost:8000/static/mycss" -c "https://example.com/css/example.css"`
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
Author
|
is there anything lacking? - I would be glad to add it if there is sthg missing |
Author
|
Is this project dead?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elm-reactor -c "http://localhost:8000/static/mycss" -c "https://example.com/css/example.css"this is my first endeavour into elm land (though i am a long-time haskell user).
I created a new flag for elm-reactor to include (multiple) css files in the generated html when I view the app to some elm-file.
hope this fixes issue #138 - if there is something missing please tell me.