Draft
Conversation
diondokter
force-pushed
the
mcxa-use-metadata
branch
from
2114905 to
1f351bd
Compare
felipebalbi
reviewed
Apr 14, 2026
Contributor
felipebalbi
left a comment
felipebalbi
left a comment
There was a problem hiding this comment.
Aren't you missing updates to the tests directory?
Comment on lines
+109
to
131
| /// Peripheral chip select pin trait. | ||
| #[allow(private_bounds)] | ||
| pub trait Pcs0Pin<Instance>: GpioPin + sealed::SealedSpiPin<Instance> + PeripheralType { | ||
| fn mux(&self); | ||
| } | ||
|
|
||
| /// Peripheral chip select or host request pin trait. | ||
| #[allow(private_bounds)] | ||
| pub trait Pcs1Pin<Instance>: GpioPin + sealed::SealedSpiPin<Instance> + PeripheralType { | ||
| fn mux(&self); | ||
| } | ||
|
|
||
| /// Peripheral chip select or data pin 2 during parallel data transfers pin trait. | ||
| #[allow(private_bounds)] | ||
| pub trait Pcs2Pin<Instance>: GpioPin + sealed::SealedSpiPin<Instance> + PeripheralType { | ||
| fn mux(&self); | ||
| } | ||
|
|
||
| /// Peripheral chip select or data pin 3 during parallel data transfers pin trait. | ||
| #[allow(private_bounds)] | ||
| pub trait Pcs3Pin<Instance>: GpioPin + sealed::SealedSpiPin<Instance> + PeripheralType { | ||
| fn mux(&self); | ||
| } |
Contributor
There was a problem hiding this comment.
we're not really using the HW-managed chip select lines
Comment on lines
+29
to
+33
| let cfg_name = match peripheral.driver_name.split_once("::") { | ||
| Some((path, _block)) => path, | ||
| None => peripheral.driver_name, | ||
| } | ||
| .replace("/", "_"); |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.