Fix Quick Start diff description and restore +/- markers (#2090) - #2231
Open
olenderhub wants to merge 1 commit into
Open
Fix Quick Start diff description and restore +/- markers (#2090)#2231olenderhub wants to merge 1 commit into
olenderhub wants to merge 1 commit into
Conversation
After the Shiki migration, diffs were color-only while the guide still described plus/minus signs. Restore visible +/- next to line numbers (using the existing Shiki add/remove colors) and align the Quick Start copy with that behavior. Keep a fixed-width gutter in diff blocks so code indentation stays aligned across added, removed, and unchanged lines.
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Thanks for doing this! The styling here doesn't look right when the line numbers increase in digits: 
|
Author
|
@kategengler thank you for reply I think better proposition about is #2090 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2090
After the Shiki migration, code diffs were highlighted with color only. The Quick Start guide still said added/removed lines would show
+/-, but those markers were gone because the old Prism CSS no longer matched Shiki’s classes.This PR restores
+/-next to line numbers on all Shiki diff blocks (using the existing Shiki add/remove colors), keeps a fixed-width gutter so indentation stays aligned, and updates the Quick Start wording to match.Text change (Quick Start only):
https://guides.emberjs.com/release/getting-started/quick-start/
Visual
+/-markers (every page with diffs, including Quick Start), e.g.:The same CSS also applies under other guide versions that use Shiki diffs (e.g.
/v7.0.0/...), since it ships in shared/assets/.