Fix CI - #713
Merged
Merged
Conversation
9 tasks
NullVoxPopuli
added a commit
that referenced
this pull request
May 6, 2026
Ember 6.10 introduced the AMD deprecation (RFC #1101): the published ember-source package will stop bundling pre-built AMD modules after Ember 7. On canary and beta, addons that still `import Ember from 'ember'` fail at boot with `Could not find module 'ember'`. Two addons in the app/addon templates trip this: - ember-resolver ^8.0.3: the v8 distribution exposes `ember-resolver/resolvers/classic/index` which imports the AMD `ember` module. Linking the canary scenario at v13.2.0 was already done in #713; do the same for beta. - ember-cli-app-version ^5.0.0: `addon/initializer-factory.js` does `import Ember from 'ember'` to read `Ember.libraries`. v7.0.0 switched to `import { libraries } from '@ember/-internals/metal'`. Link both canary and beta to ^7.0.0. Both upgrades are scoped to the canary/beta scenarios via `linkDevDependency` so the LTS/3.x/release scenarios continue to exercise the older versions. Verified locally: canary-babel, canary-csp, canary-doubly-indirect, canary-layering, beta-babel, beta-common-chunk, beta-custom-html now pass. Fastboot-using scenarios (canary-dynamic-import, beta-import-sync, *-v2-addon) still fail because ember-cli-fastboot 4.1.5 (latest) imports `Ember` from AMD and uses the removed `inject as service` shape — those need a separate fix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
NullVoxPopuli
marked this pull request as ready for review
May 6, 2026 04:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note:
import * as name......so, I'm disabling fastboot on beta and canary