Skip to content

[OpenAL] Fix sourceSeek crash on stopped sources #26770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uniformization wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[OpenAL] Fix sourceSeek crash on stopped sources #26770

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e5f797
Fix sourceSeek crash on stopped sources
uniformization Apr 24, 2026
723c98a
Add AL_SEC_OFFSET test for stopped sounds
uniformization Apr 25, 2026
d67e7d8
Add changes according the review
uniformization Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/lib/libopenal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,13 +724,17 @@ var LibraryOpenAL = {
AL.setSourceState(src, {{{ cDefs.AL_INITIAL }}});
}

if (src.bufQueue[src.bufsProcessed].audioBuf !== null) {
src.bufsProcessed = 0;
while (offset > src.bufQueue[src.bufsProcessed].audioBuf.duration) {
src.bufsProcessed = 0;
if (src.bufQueue.length > 0 && src.bufQueue[0].audioBuf !== null) {
Comment thread
uniformization marked this conversation as resolved.
Outdated
while (src.bufsProcessed < src.bufQueue.length && offset > src.bufQueue[src.bufsProcessed].audioBuf.duration) {
offset -= src.bufQueue[src.bufsProcessed].audioBuf.duration;
src.bufsProcessed++;
}

if (src.bufsProcessed >= src.bufQueue.length) {
Comment thread
uniformization marked this conversation as resolved.
Outdated
src.bufsProcessed = src.bufQueue.length -1;
Comment thread
uniformization marked this conversation as resolved.
Outdated
}

src.bufOffset = offset;
}

Expand Down