-
Notifications
You must be signed in to change notification settings - Fork 15
Add per-segment transcript support for audio objects #1093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
encordrob
wants to merge
2
commits into
master
Choose a base branch
from
encordrob/review-critique-first
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| """--- | ||
| title: "Objects - Transcripts" | ||
| slug: "sdk-ref-objects-transcript" | ||
| hidden: false | ||
| metadata: | ||
| title: "Objects - Transcripts" | ||
| description: "Encord SDK Objects - Transcript segment data class." | ||
| category: "64e481b57b6027003f20aaa0" | ||
| --- | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from dataclasses import dataclass | ||
| from typing import Any, Mapping, Tuple | ||
|
|
||
| from encord.objects.attributes import Attribute | ||
|
|
||
| # Marker substring used in the ontology attribute display name to identify | ||
| # transcript-bearing text attributes. There is no schema flag for this yet; | ||
| # the marker is the only signal the FE and SDK agree on. | ||
| TRANSCRIPT_NAME_MARKER = "#transcript" | ||
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class TranscriptSegment: | ||
| """One playback segment of a transcript on an ObjectInstance. | ||
|
|
||
| A transcript-bearing attribute on an object may have multiple segments, | ||
| each with its own frame range and text. A single segment with multiple | ||
| sub-ranges in the underlying label is unrolled into one TranscriptSegment | ||
| per sub-range, all sharing the same text. | ||
| """ | ||
|
|
||
| range: Tuple[int, int] | ||
| text: str | ||
| feature_hash: str | ||
| attribute_name: str | ||
|
|
||
|
|
||
| def is_transcript_attribute(attribute: Attribute) -> bool: | ||
| return TRANSCRIPT_NAME_MARKER in attribute.name | ||
|
|
||
|
|
||
| def is_transcript_raw_entry(entry: Mapping[str, Any]) -> bool: | ||
| name = entry.get("name") | ||
| return isinstance(name, str) and TRANSCRIPT_NAME_MARKER in name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic for filtering, sorting, and joining transcript segments is duplicated between
get_answerandget_transcripts. Refactoringget_answerto callget_transcriptswould improve maintainability and ensure consistent behavior across the SDK.